netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Claudio Lanconelli <lanconelli.claudio@eptar.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] enc28j60: Fix sporadic packet loss
Date: Tue, 02 Dec 2008 15:11:26 +0100	[thread overview]
Message-ID: <4935420E.1010809@eptar.com> (raw)
In-Reply-To: <20081202125046.GD24490@diamond.tkos.co.il>

Baruch Siach wrote:
> +/*
> + * Calculate wrap arround when reading beyond the end of the RX buffer
                      ^
> + */
> +static u16 rx_packet_start(u16 ptr)
> +{
> +	if (ptr + RSV_SIZE > RXEND_INIT)
> +		return (ptr + RSV_SIZE) - (RXEND_INIT - RXSTART_INIT + 1);
> +	else
> +		return ptr;
> +}

should be
...
	else
		return ptr + RSV_SIZE;

With this change you can add the line
Acked-by: Claudio Lanconelli <lanconelli.claudio@eptar.com>


Cheers,
Claudio


      reply	other threads:[~2008-12-02 16:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-02 12:50 [PATCH] enc28j60: Fix sporadic packet loss Baruch Siach
2008-12-02 14:11 ` Claudio Lanconelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4935420E.1010809@eptar.com \
    --to=lanconelli.claudio@eptar.com \
    --cc=baruch@tkos.co.il \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).