netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Hartkopp <oliver@hartkopp.net>
To: David Miller <davem@davemloft.net>
Cc: greg@kroah.com, kurt.van.dijck@eia.be, netdev@vger.kernel.org,
	stable@kernel.org
Subject: Re: [PATCH] can: Fix CAN_(EFF|RTR)_FLAG handling in can_filter
Date: Thu, 04 Dec 2008 17:52:29 +0100	[thread overview]
Message-ID: <49380ACD.1060009@hartkopp.net> (raw)
In-Reply-To: <20081203.155354.206786507.davem@davemloft.net>

David Miller wrote:
> From: Oliver Hartkopp <oliver@hartkopp.net>
> Date: Mon, 01 Dec 2008 17:15:42 +0100
>
>   
>> can: Fix CAN_(EFF|RTR)_FLAG handling in can_filter
>>
>>     
>
> Applied to net-2.6
>   

Thanks!

> But you are totally kidding yourself if you think that bumping
> that completely stupid date string has any meaning at all for
> userspace.
>
> You're either keeping to the API you're exporting to userspace
> or you're not.  And using a date string which userland has to
> test is just a cop-out for not breaking userspace interfaces.
>   

This fix does fortunately not break the userspace interface.

The version string is just for information and should not be used to 
determine changing userspace interfaces. Thinking about your concerns it 
may be the best approach to remove this version stuff entirely, before 
people begin to use it in any weird manner :-/

I'll make a RFC on the CAN ML if it can be removed.

Thanks for the feedback,

Oliver


  reply	other threads:[~2008-12-04 16:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20081128153317.GA3726@e-circ.dyndns.org>
2008-12-01 16:15 ` [PATCH] can: Fix CAN_(EFF|RTR)_FLAG handling in can_filter Oliver Hartkopp
2008-12-01 17:52   ` Sam Ravnborg
2008-12-01 18:42     ` Oliver Hartkopp
2008-12-01 18:52       ` Sam Ravnborg
2008-12-02 10:01       ` Kurt Van Dijck
2008-12-03 23:53   ` David Miller
2008-12-04 16:52     ` Oliver Hartkopp [this message]
2008-12-04 17:40 ` [PATCH net-2.6] can: omit received RTR frames for single ID filter lists Oliver Hartkopp
2008-12-04 23:01   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49380ACD.1060009@hartkopp.net \
    --to=oliver@hartkopp.net \
    --cc=davem@davemloft.net \
    --cc=greg@kroah.com \
    --cc=kurt.van.dijck@eia.be \
    --cc=netdev@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).