* [PATCH next] staging-slicoss: Kill directly reference of netdev->priv
@ 2008-12-05 15:21 Wang Chen
2008-12-07 7:59 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Wang Chen @ 2008-12-05 15:21 UTC (permalink / raw)
To: David S. Miller, NETDEV; +Cc: gregkh
Simply replace netdev->priv with netdev_priv().
Compile test only.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
---
drivers/staging/slicoss/slicoss.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 8fa9490..0039036 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -765,8 +765,7 @@ static int slic_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
#ifdef SLIC_USER_REQUEST_DUMP_ENABLED
case SIOCSLICDUMPCARD:
{
- struct adapter *adapter = (struct adapter *)
- dev->priv;
+ struct adapter *adapter = netdev_priv(dev);
struct sliccard *card;
ASSERT(adapter);
@@ -1685,7 +1684,7 @@ static void slic_timer_ping(ulong dev)
struct sliccard *card;
ASSERT(dev);
- adapter = (struct adapter *)((struct net_device *) dev)->priv;
+ adapter = netdev_priv((struct net_device *)dev);
ASSERT(adapter);
card = adapter->card;
ASSERT(card);
@@ -3136,7 +3135,7 @@ static void slic_timer_get_stats(ulong dev)
struct slic_shmem *pshmem;
ASSERT(dev);
- adapter = (struct adapter *)((struct net_device *)dev)->priv;
+ adapter = netdev_priv((struct net_device *)dev);
ASSERT(adapter);
card = adapter->card;
ASSERT(card);
--
1.5.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH next] staging-slicoss: Kill directly reference of netdev->priv
2008-12-05 15:21 [PATCH next] staging-slicoss: Kill directly reference of netdev->priv Wang Chen
@ 2008-12-07 7:59 ` David Miller
2008-12-08 0:32 ` Wang Chen
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2008-12-07 7:59 UTC (permalink / raw)
To: wangchen; +Cc: netdev, gregkh
From: Wang Chen <wangchen@cn.fujitsu.com>
Date: Fri, 05 Dec 2008 23:21:15 +0800
> Simply replace netdev->priv with netdev_priv().
>
> Compile test only.
>
> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Also applied, thanks Wang.
Wang, how much more of this stuff do you estimate we still
have to fix up before we can really kill off ->priv?
Just curious...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH next] staging-slicoss: Kill directly reference of netdev->priv
2008-12-07 7:59 ` David Miller
@ 2008-12-08 0:32 ` Wang Chen
0 siblings, 0 replies; 3+ messages in thread
From: Wang Chen @ 2008-12-08 0:32 UTC (permalink / raw)
To: David Miller; +Cc: netdev, gregkh
David Miller said the following on 2008-12-7 15:59:
> From: Wang Chen <wangchen@cn.fujitsu.com>
> Date: Fri, 05 Dec 2008 23:21:15 +0800
>
>> Simply replace netdev->priv with netdev_priv().
>>
>> Compile test only.
>>
>> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
>
> Also applied, thanks Wang.
>
> Wang, how much more of this stuff do you estimate we still
> have to fix up before we can really kill off ->priv?
>
> Just curious...
>
Only one left, as I grepped last week.
I will finish it this week.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-08 0:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-05 15:21 [PATCH next] staging-slicoss: Kill directly reference of netdev->priv Wang Chen
2008-12-07 7:59 ` David Miller
2008-12-08 0:32 ` Wang Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).