From: Patrick McHardy <kaber@trash.net>
To: Julia Lawall <julia@diku.dk>
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi,
jmorris@namei.org, yoshfuji@linux-ipv6.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net/netfilter: simplify error handling
Date: Fri, 05 Dec 2008 16:22:22 +0100 [thread overview]
Message-ID: <4939472E.7060804@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0812051234230.9560@pc-004.diku.dk>
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> nf_conntrack_alloc cannot return NULL, so there is no need to check for
> NULL before using the value. I have also removed the initialization of ct
> to NULL in nf_conntrack_alloc, since the value is never used, and since
> perhaps it might lead one to think that return ct at the end might return
> NULL.
Applied, thanks.
prev parent reply other threads:[~2008-12-05 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 11:34 [PATCH] net/netfilter: simplify error handling Julia Lawall
2008-12-05 15:22 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4939472E.7060804@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).