From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] net/netfilter: simplify error handling Date: Fri, 05 Dec 2008 16:22:22 +0100 Message-ID: <4939472E.7060804@trash.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org To: Julia Lawall Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Julia Lawall wrote: > From: Julia Lawall > > nf_conntrack_alloc cannot return NULL, so there is no need to check for > NULL before using the value. I have also removed the initialization of ct > to NULL in nf_conntrack_alloc, since the value is never used, and since > perhaps it might lead one to think that return ct at the end might return > NULL. Applied, thanks.