netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Sathya Perla <sathyap@serverengines.com>
Cc: netdev <netdev@vger.kernel.org>,
	jgarzik@pobox.com, jeff@garzik.org,
	subbu <subbus@serverengines.com>
Subject: Re: [PATCH 02/11] benet: interrupt/i/o handling, network layer i/f and ethtool functions
Date: Tue, 09 Dec 2008 15:34:27 +0100	[thread overview]
Message-ID: <493E81F3.60800@trash.net> (raw)
In-Reply-To: <1228832399.6435.95.camel@sperla-laptop>

Sathya Perla wrote:
> +/*
> + * This is the driver entry point to add a vlan vlan_id
> + * with the device netdev
> + */
> +static void benet_vlan_add_vid(struct net_device *netdev, u16 vlan_id)
> +{
> +	struct be_net_object *pnob = netdev->priv;
> +
> +	if (pnob->num_vlans == (BE_NUM_VLAN_SUPPORTED - 1)) {
> +		/* no  way to return an error */
> +		dev_info(&netdev->dev,
> +		       "BladeEngine: Cannot configure more than %d Vlans\n",
> +			       BE_NUM_VLAN_SUPPORTED);
> +		return;

I'd suggest to either make ->vlan_add_vid() return an error code
or disable VLAN hardware filtering completely when you exceed the
number of supported VLANs. The later is probably the better choice
since people expect to be able to add any number of VLANs.


  reply	other threads:[~2008-12-09 14:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-09 14:19 [PATCH 02/11] benet: interrupt/i/o handling, network layer i/f and ethtool functions Sathya Perla
2008-12-09 14:34 ` Patrick McHardy [this message]
2008-12-10  6:45 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493E81F3.60800@trash.net \
    --to=kaber@trash.net \
    --cc=jeff@garzik.org \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    --cc=sathyap@serverengines.com \
    --cc=subbus@serverengines.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).