From: Dan Carpenter <dan.carpenter@linaro.org>
To: Su Hui <suhui@nfschina.com>
Cc: irusskikh@marvell.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, yunchuan@nfschina.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next v2 02/10] net: atlantic: Remove unnecessary (void*) conversions
Date: Mon, 10 Jul 2023 10:31:47 +0300 [thread overview]
Message-ID: <494050a5-4bed-44d0-90d0-e76726168791@kadam.mountain> (raw)
In-Reply-To: <20230710063952.173055-1-suhui@nfschina.com>
On Mon, Jul 10, 2023 at 02:39:52PM +0800, Su Hui wrote:
> static void hw_atl2_hw_init_new_rx_filters(struct aq_hw_s *self)
> {
> - struct hw_atl2_priv *priv = (struct hw_atl2_priv *)self->priv;
> u8 *prio_tc_map = self->aq_nic_cfg->prio_tc_map;
> + struct hw_atl2_priv *priv = self->priv;
> u16 action;
> u8 index;
> int i;
In this case moving the variable is fine because it's related to
removing the cast. But in the other case it was moving other
decalarations so it wasn't related.
regards,
dan carpenter
prev parent reply other threads:[~2023-07-10 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 6:39 [PATCH net-next v2 02/10] net: atlantic: Remove unnecessary (void*) conversions Su Hui
2023-07-10 7:31 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494050a5-4bed-44d0-90d0-e76726168791@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=irusskikh@marvell.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=suhui@nfschina.com \
--cc=yunchuan@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox