* [PATCH 5/9][v2] mISDN: fix sparse warning: symbol 'nskb' shadows an earlier one
@ 2008-12-11 21:36 Hannes Eder
2008-12-13 5:17 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Eder @ 2008-12-11 21:36 UTC (permalink / raw)
To: netdev; +Cc: Karsten Keil, linux-kernel, kernel-janitors
Impact: define first occurence of variable 'nskb' in inner most possible scope
Fix this sparse warning:
drivers/isdn/mISDN/dsp_core.c:746:20: warning: symbol 'nskb' shadows an earlier one
drivers/isdn/mISDN/dsp_core.c:634:19: originally declared here
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Acked-by: Karsten Keil <kkeil@suse.de>
---
drivers/isdn/mISDN/dsp_core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/mISDN/dsp_core.c b/drivers/isdn/mISDN/dsp_core.c
index 41af063..1dc21d8 100644
--- a/drivers/isdn/mISDN/dsp_core.c
+++ b/drivers/isdn/mISDN/dsp_core.c
@@ -631,7 +631,6 @@ dsp_function(struct mISDNchannel *ch, struct sk_buff *skb)
int ret = 0;
u8 *digits;
int cont;
- struct sk_buff *nskb;
u_long flags;
hh = mISDN_HEAD_P(skb);
@@ -690,6 +689,7 @@ dsp_function(struct mISDNchannel *ch, struct sk_buff *skb)
digits = dsp_dtmf_goertzel_decode(dsp, skb->data,
skb->len, (dsp_options&DSP_OPT_ULAW)?1:0);
while (*digits) {
+ struct sk_buff *nskb;
if (dsp_debug & DEBUG_DSP_DTMF)
printk(KERN_DEBUG "%s: digit"
"(%c) to layer %s\n",
--
1.5.6.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 5/9][v2] mISDN: fix sparse warning: symbol 'nskb' shadows an earlier one
2008-12-11 21:36 [PATCH 5/9][v2] mISDN: fix sparse warning: symbol 'nskb' shadows an earlier one Hannes Eder
@ 2008-12-13 5:17 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-12-13 5:17 UTC (permalink / raw)
To: hannes; +Cc: netdev, kkeil, linux-kernel, kernel-janitors
From: Hannes Eder <hannes@hanneseder.net>
Date: Thu, 11 Dec 2008 22:36:00 +0100
> Impact: define first occurence of variable 'nskb' in inner most possible scope
>
> Fix this sparse warning:
>
> drivers/isdn/mISDN/dsp_core.c:746:20: warning: symbol 'nskb' shadows an earlier one
> drivers/isdn/mISDN/dsp_core.c:634:19: originally declared here
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
> Acked-by: Karsten Keil <kkeil@suse.de>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-13 5:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-11 21:36 [PATCH 5/9][v2] mISDN: fix sparse warning: symbol 'nskb' shadows an earlier one Hannes Eder
2008-12-13 5:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).