* [PATCH 8/9][v2] mISDN: timerdev: use __user for mISDN_read's buffer argument
@ 2008-12-11 21:36 Hannes Eder
2008-12-13 5:19 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Eder @ 2008-12-11 21:36 UTC (permalink / raw)
To: netdev; +Cc: Karsten Keil, linux-kernel, kernel-janitors
Fix this warning:
drivers/isdn/mISDN/timerdev.c:264:11: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
drivers/isdn/mISDN/timerdev.c:264:11: expected int ( *read )( ... )
drivers/isdn/mISDN/timerdev.c:264:11: got int ( static [toplevel] *<noident> )( ... )
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Acked-by: Karsten Keil <kkeil@suse.de>
---
drivers/isdn/mISDN/timerdev.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/isdn/mISDN/timerdev.c b/drivers/isdn/mISDN/timerdev.c
index 62b5e49..f2b3218 100644
--- a/drivers/isdn/mISDN/timerdev.c
+++ b/drivers/isdn/mISDN/timerdev.c
@@ -86,7 +86,7 @@ mISDN_close(struct inode *ino, struct file *filep)
}
static ssize_t
-mISDN_read(struct file *filep, char *buf, size_t count, loff_t *off)
+mISDN_read(struct file *filep, char __user *buf, size_t count, loff_t *off)
{
struct mISDNtimerdev *dev = filep->private_data;
struct mISDNtimer *timer;
@@ -116,7 +116,7 @@ mISDN_read(struct file *filep, char *buf, size_t count, loff_t *off)
timer = (struct mISDNtimer *)dev->expired.next;
list_del(&timer->list);
spin_unlock_irqrestore(&dev->lock, flags);
- if (put_user(timer->id, (int *)buf))
+ if (put_user(timer->id, (int __user *)buf))
ret = -EFAULT;
else
ret = sizeof(int);
--
1.5.6.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 8/9][v2] mISDN: timerdev: use __user for mISDN_read's buffer argument
2008-12-11 21:36 [PATCH 8/9][v2] mISDN: timerdev: use __user for mISDN_read's buffer argument Hannes Eder
@ 2008-12-13 5:19 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-12-13 5:19 UTC (permalink / raw)
To: hannes; +Cc: netdev, kkeil, linux-kernel, kernel-janitors
From: Hannes Eder <hannes@hanneseder.net>
Date: Thu, 11 Dec 2008 22:36:00 +0100
> Fix this warning:
>
> drivers/isdn/mISDN/timerdev.c:264:11: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
> drivers/isdn/mISDN/timerdev.c:264:11: expected int ( *read )( ... )
> drivers/isdn/mISDN/timerdev.c:264:11: got int ( static [toplevel] *<noident> )( ... )
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
> Acked-by: Karsten Keil <kkeil@suse.de>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-13 5:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-11 21:36 [PATCH 8/9][v2] mISDN: timerdev: use __user for mISDN_read's buffer argument Hannes Eder
2008-12-13 5:19 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).