From: James Chapman <jchapman@katalix.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, wangchen@cn.fujitsu.com
Subject: Re: [PATCH] ppp: fix segfaults introduced by netdev_priv changes
Date: Thu, 18 Dec 2008 10:28:19 +0000 [thread overview]
Message-ID: <494A25C3.1050603@katalix.com> (raw)
In-Reply-To: <20081217.192047.117548302.davem@davemloft.net>
David Miller wrote:
> From: James Chapman <jchapman@katalix.com>
> Date: Wed, 17 Dec 2008 22:02:16 GMT
>
>> + } else
>> + ppp_unlock(ppp);
>> +
>> cardmap_set(&all_ppp_units, ppp->file.index, NULL);
>> ppp->file.dead = 1;
>> ppp->owner = NULL;
>
> James, thanks for this fix. But you'll need to respin this
> as it conflicts with the IDR changes that are in net-next-2.6
> (this cardmap_set call isn't there any more, for example).
The patch is against net-2.6. I assumed it was appropriate for net-2.6
since we're on rc8 and ppp has been broken since rc6. :) Sorry I didn't
mention that in the patch.
I'll spin a version for net-next-2.6 later today.
--
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development
next prev parent reply other threads:[~2008-12-18 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 22:02 [PATCH] ppp: fix segfaults introduced by netdev_priv changes James Chapman
2008-12-18 2:15 ` Wang Chen
2008-12-18 10:24 ` James Chapman
2008-12-18 3:20 ` David Miller
2008-12-18 10:28 ` James Chapman [this message]
2008-12-19 3:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494A25C3.1050603@katalix.com \
--to=jchapman@katalix.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).