From: Wang Chen <wangchen@cn.fujitsu.com>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: julia@diku.dk, David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: Fix oops in dev_ifsioc()
Date: Fri, 19 Dec 2008 16:14:54 +0800 [thread overview]
Message-ID: <494B57FE.3070706@cn.fujitsu.com> (raw)
In-Reply-To: <20081219081104.GB7189@ff.dom.local>
Jarek Poplawski said the following on 2008-12-19 16:11:
> On Fri, Dec 19, 2008 at 04:02:51PM +0800, Wang Chen wrote:
>> Jarek Poplawski said the following on 2008-12-19 15:04:
>>> A command like this: "brctl addif br1 eth1" issued as a user gave me
>>> an oops when bridge module wasn't loaded. It's caused by using a dev
>>> pointer before checking for NULL.
> ...
>> Subject will be changed, sorry.
>> Seems Julia is doing "Move a dereference below a NULL test" check,
>> but why the coccinelle missed this one?
>
> Probably because it's quite fresh?
>
Yes. Maybe Julia never check the source of -next. :)
next prev parent reply other threads:[~2008-12-19 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 7:04 [PATCH] net: Fix oops in dev_ifsioc() Jarek Poplawski
2008-12-19 8:02 ` Wang Chen
2008-12-19 8:11 ` Jarek Poplawski
2008-12-19 8:14 ` Wang Chen [this message]
2008-12-19 8:33 ` Julia Lawall
2008-12-23 3:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494B57FE.3070706@cn.fujitsu.com \
--to=wangchen@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=julia@diku.dk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).