From: Wang Chen <wangchen@cn.fujitsu.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Roland Dreier <rdreier@cisco.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, sean.hefty@intel.com,
Aleksey Senin <alekseys@voltaire.com>
Subject: Re: 2.6.28-git1 build failure
Date: Mon, 29 Dec 2008 15:44:29 +0800 [thread overview]
Message-ID: <49587FDD.5000504@cn.fujitsu.com> (raw)
In-Reply-To: <495853C6.6030000@oracle.com>
Randy Dunlap said the following on 2008-12-29 12:36:
> drivers/built-in.o: In function `addr_resolve_remote':
> addr.c:(.text+0x12fe75): undefined reference to `ip6_route_output'
> drivers/built-in.o: In function `rdma_translate_ip':
> (.text+0x1301a7): undefined reference to `ipv6_chk_addr'
> drivers/built-in.o: In function `rdma_resolve_ip':
> (.text+0x1303a9): undefined reference to `ipv6_chk_addr'
> drivers/built-in.o: In function `rdma_resolve_ip':
> (.text+0x13051b): undefined reference to `ip6_route_output'
>
> when CONFIG_IPV6=n.
>
Aleksey added IPv6 function to it but not change the Kconfig file.
The following patch will temporarily fix this build failure.
But IMHO separating the IPv4/IPv6 parts or using #ifdef would be better.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
---
diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
index a5dc78a..9535e13 100644
--- a/drivers/infiniband/Kconfig
+++ b/drivers/infiniband/Kconfig
@@ -36,7 +36,7 @@ config INFINIBAND_USER_MEM
config INFINIBAND_ADDR_TRANS
bool
- depends on INET
+ depends on INET && IPV6
default y
source "drivers/infiniband/hw/mthca/Kconfig"
next prev parent reply other threads:[~2008-12-29 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 4:36 2.6.28-git1 build failure Randy Dunlap
2008-12-29 7:44 ` Wang Chen [this message]
2008-12-29 9:24 ` Ingo Molnar
2008-12-29 9:33 ` Wang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49587FDD.5000504@cn.fujitsu.com \
--to=wangchen@cn.fujitsu.com \
--cc=alekseys@voltaire.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).