From: Li Zefan <lizf@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: cls_cgroup: clean up for cgroup part
Date: Tue, 30 Dec 2008 11:43:56 +0800 [thread overview]
Message-ID: <495998FC.8050503@cn.fujitsu.com> (raw)
In-Reply-To: <20081229.193836.123306072.davem@davemloft.net>
David Miller wrote:
> Actually, the tree doesn't even build after applying this
> patch.
>
> How did you test this?
>
> net/sched/cls_cgroup.c: In function ‘write_classid’:
> net/sched/cls_cgroup.c:68: error: implicit declaration of function ‘net_cls_state’
> net/sched/cls_cgroup.c:68: error: invalid type argument of ‘->’
>
> I made the obvious fixup to this change, but...
>
> Come on, build test your changes. :-(
>
Ouch, sorry.. I did a fixup when I was making those patches,
but forgot to update the patch..
prev parent reply other threads:[~2008-12-30 3:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-30 3:07 cls_cgroup: clean up for cgroup part David Miller
2008-12-30 3:38 ` David Miller
2008-12-30 3:43 ` Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495998FC.8050503@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).