* Re: cls_cgroup: clean up for cgroup part
@ 2008-12-30 3:07 David Miller
2008-12-30 3:38 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2008-12-30 3:07 UTC (permalink / raw)
To: lizf; +Cc: netdev
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: cls_cgroup: clean up for cgroup part
2008-12-30 3:07 cls_cgroup: clean up for cgroup part David Miller
@ 2008-12-30 3:38 ` David Miller
2008-12-30 3:43 ` Li Zefan
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2008-12-30 3:38 UTC (permalink / raw)
To: lizf; +Cc: netdev
Actually, the tree doesn't even build after applying this
patch.
How did you test this?
net/sched/cls_cgroup.c: In function ‘write_classid’:
net/sched/cls_cgroup.c:68: error: implicit declaration of function ‘net_cls_state’
net/sched/cls_cgroup.c:68: error: invalid type argument of ‘->’
I made the obvious fixup to this change, but...
Come on, build test your changes. :-(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: cls_cgroup: clean up for cgroup part
2008-12-30 3:38 ` David Miller
@ 2008-12-30 3:43 ` Li Zefan
0 siblings, 0 replies; 3+ messages in thread
From: Li Zefan @ 2008-12-30 3:43 UTC (permalink / raw)
To: David Miller; +Cc: netdev
David Miller wrote:
> Actually, the tree doesn't even build after applying this
> patch.
>
> How did you test this?
>
> net/sched/cls_cgroup.c: In function ‘write_classid’:
> net/sched/cls_cgroup.c:68: error: implicit declaration of function ‘net_cls_state’
> net/sched/cls_cgroup.c:68: error: invalid type argument of ‘->’
>
> I made the obvious fixup to this change, but...
>
> Come on, build test your changes. :-(
>
Ouch, sorry.. I did a fixup when I was making those patches,
but forgot to update the patch..
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-30 3:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-30 3:07 cls_cgroup: clean up for cgroup part David Miller
2008-12-30 3:38 ` David Miller
2008-12-30 3:43 ` Li Zefan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).