* [PATCH] DCB: fix kfree(skb)
@ 2009-01-02 13:03 Roel Kluin
2009-01-05 1:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-01-02 13:03 UTC (permalink / raw)
To: alexander.h.duyck, jeffrey.t.kirsher; +Cc: netdev
Use kfree_skb instead of kfree for struct sk_buff pointers.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index 5dbfe5f..8379496 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -191,7 +191,7 @@ static int dcbnl_reply(u8 value, u8 event, u8 cmd, u8 attr, u32 pid,
return 0;
nlmsg_failure:
err:
- kfree(dcbnl_skb);
+ kfree_skb(dcbnl_skb);
return ret;
}
@@ -272,7 +272,7 @@ static int dcbnl_getpfccfg(struct net_device *netdev, struct nlattr **tb,
return 0;
nlmsg_failure:
err:
- kfree(dcbnl_skb);
+ kfree_skb(dcbnl_skb);
err_out:
return -EINVAL;
}
@@ -314,7 +314,7 @@ static int dcbnl_getperm_hwaddr(struct net_device *netdev, struct nlattr **tb,
nlmsg_failure:
err:
- kfree(dcbnl_skb);
+ kfree_skb(dcbnl_skb);
err_out:
return -EINVAL;
}
@@ -380,7 +380,7 @@ static int dcbnl_getcap(struct net_device *netdev, struct nlattr **tb,
return 0;
nlmsg_failure:
err:
- kfree(dcbnl_skb);
+ kfree_skb(dcbnl_skb);
err_out:
return -EINVAL;
}
@@ -458,7 +458,7 @@ static int dcbnl_getnumtcs(struct net_device *netdev, struct nlattr **tb,
return 0;
nlmsg_failure:
err:
- kfree(dcbnl_skb);
+ kfree_skb(dcbnl_skb);
err_out:
return ret;
}
@@ -687,7 +687,7 @@ err_pg:
nla_nest_cancel(dcbnl_skb, pg_nest);
nlmsg_failure:
err:
- kfree(dcbnl_skb);
+ kfree_skb(dcbnl_skb);
err_out:
ret = -EINVAL;
return ret;
@@ -949,7 +949,7 @@ err_bcn:
nla_nest_cancel(dcbnl_skb, bcn_nest);
nlmsg_failure:
err:
- kfree(dcbnl_skb);
+ kfree_skb(dcbnl_skb);
err_out:
ret = -EINVAL;
return ret;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] DCB: fix kfree(skb)
2009-01-02 13:03 [PATCH] DCB: fix kfree(skb) Roel Kluin
@ 2009-01-05 1:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-01-05 1:29 UTC (permalink / raw)
To: roel.kluin; +Cc: alexander.h.duyck, jeffrey.t.kirsher, netdev
From: Roel Kluin <roel.kluin@gmail.com>
Date: Fri, 02 Jan 2009 14:03:18 +0100
> Use kfree_skb instead of kfree for struct sk_buff pointers.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Applied, thanks a lot Roel.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-05 1:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-02 13:03 [PATCH] DCB: fix kfree(skb) Roel Kluin
2009-01-05 1:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).