From: Rick Jones <rick.jones2@hp.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] Make possible speeds known to ethtool
Date: Thu, 08 Jan 2009 11:11:57 -0800 [thread overview]
Message-ID: <49664FFD.1010608@hp.com> (raw)
In-Reply-To: <49656F01.3090603@pobox.com>
Jeff Garzik wrote:
> Ben Hutchings wrote:
>> The vetting of speeds is kind of silly. Given that speed is established
>> as being a number of Mbit/s (hence the need for speed_hi), why not
>> remove the warning and the checks for known values and report it as
>> such?
>
>
> I'm ok with that route. Historically it made sense, but AFAICS the
> driver _must_ verify the speed anyway, so removing the limitation in the
> userspace tool seems reasonable.
>
> The next release of ethtool is coming in about 4 weeks, and we can
> definitely get something like this in there.
I have a simple patch which does just that ready to post, but will
point-out that removing the checks entirely will result in the speed
being reported as 65535 (without Unknown) for an interface with its
cable disconnected. This however is is based only on "testing" on a
2.6.24-22-generic (hardy) kernel with 7.3.20-k2-NAPI of the e1000 driver
driving an Intel 82566MM (rev 03).
rick jones
next prev parent reply other threads:[~2009-01-08 19:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 2:03 [PATCH] Make possible speeds known to ethtool Rick Jones
2009-01-08 3:14 ` Ben Hutchings
2009-01-08 3:12 ` Jeff Garzik
2009-01-08 19:11 ` Rick Jones [this message]
2009-01-08 19:25 ` Ben Hutchings
2009-01-08 19:50 ` Rick Jones
2009-01-09 13:16 ` [PATCH] ethtool: Support arbitrary speeds Ben Hutchings
2009-01-09 17:55 ` Rick Jones
2009-01-09 18:24 ` Ben Hutchings
2009-01-09 18:40 ` Rick Jones
2009-03-06 11:20 ` Jeff Garzik
2009-03-06 12:27 ` Jeff Garzik
2009-01-09 2:52 ` [PATCH] Make possible speeds known to ethtool Herbert Xu
2009-01-09 3:20 ` Jeff Garzik
2009-03-06 11:19 ` Jeff Garzik
2009-03-06 13:52 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2009-01-09 3:48 Herbert Xu
2009-01-09 3:58 ` Jeff Garzik
2009-01-09 4:19 Herbert Xu
2009-01-09 5:00 ` David Miller
2009-01-09 5:05 ` Jeff Garzik
2009-01-09 5:03 ` Jeff Garzik
2009-01-09 5:15 ` Herbert Xu
2009-01-09 5:30 ` Jeff Garzik
2009-01-09 5:35 ` Herbert Xu
2009-01-09 6:28 ` Jeff Garzik
2009-01-09 6:30 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49664FFD.1010608@hp.com \
--to=rick.jones2@hp.com \
--cc=bhutchings@solarflare.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).