netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: ipng@69706e6720323030352d30312d31340a.nosense.org,
	netdev@vger.kernel.org
Subject: Re: Is it valid to add a macvlan virtual interface to a bridge? If so, there seems to be a bug with it.
Date: Mon, 12 Jan 2009 05:55:25 +0100	[thread overview]
Message-ID: <496ACD3D.6000608@trash.net> (raw)
In-Reply-To: <E1LD9nz-0007sR-OP@gondolin.me.apana.org.au>

Herbert Xu wrote:
> Patrick McHardy <kaber@trash.net> wrote:
>>> I've had a look at the dev.c file in 2.6.27, and my very naive guess
>>> is that as the handle_bridge() call is before the handle_macvlan() call,
>>> because the incoming real physical interface is not part of the bridge,
>>> the incoming unicast packet is being dropped, before the macvlan code
>>> gets a look at it.
>> Yes, that seems correct.
> 
> Would it be possible to implement promiscuous mode for macvlans by
> simply keeping a separate list of macvlan devices in promiscuous
> mode and sending all inbound packets to them?
> 
> This should make bridging work, right?

I think that should work, at least if we also put the underlying device
in promiscous mode. It wouldn't really be *mac*vlan anymore though :)

I've put it on my TODO list, though I won't be able to take care
of this any time soon.

      reply	other threads:[~2009-01-12  4:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04 10:03 Is it valid to add a macvlan virtual interface to a bridge? If so, there seems to be a bug with it Mark Smith
2008-12-04 13:01 ` Patrick McHardy
2008-12-05 17:43   ` Ben Greear
2008-12-05 22:54     ` Mark Smith
2008-12-06  0:08       ` Ben Greear
2008-12-06  0:26         ` Stephen Hemminger
2008-12-06  0:43           ` Ben Greear
2008-12-18  3:44   ` Herbert Xu
2009-01-12  4:55     ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496ACD3D.6000608@trash.net \
    --to=kaber@trash.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=ipng@69706e6720323030352d30312d31340a.nosense.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).