From: Divy Le Ray <divy@chelsio.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Jeff Garzik <jeff@garzik.org>, netdev@vger.kernel.org
Subject: Re: [PATCH] cxgb3: Keep LRO off if disabled when interface is down
Date: Sun, 11 Jan 2009 21:10:54 -0800 [thread overview]
Message-ID: <496AD0DE.2020009@chelsio.com> (raw)
In-Reply-To: <adaljtimh4m.fsf@cisco.com>
Roland Dreier wrote:
> I have a system with a Chelsio adapter (driven by cxgb3) whose ports are
> part of a Linux bridge. Recently I updated the kernel and discovered
> that things stopped working because cxgb3 was doing LRO on packets that
> were passed into the bridge code for forwarding. (Incidentally, this
> problem manifested itself in a strange way that made debugging a bit
> interesting -- for some reason, the skb_warn_if_lro() check in bridge
> didn't trigger and these LROed packets were forwarded out a forcedeth
> interface, and caused the forcedeth transmit path to get stuck)
>
> This is because cxgb3 has no way of keeping state for the LRO flag until
> the interface is brought up, so if the bridging code disables LRO while
> the interface is down, then cxgb3_up() will just reenable LRO, and on my
> Debian system at least, the init scripts add interfaces to a bridge
> before bringing the interfaces up.
>
> Fix this by keeping track of each interface's LRO state in cxgb3 so that
> when bridge disables LRO, it stays disabled in cxgb3_up() when the
> interface is brought up. I did this by changing the rx_csum_offload
> flag into a pair of bit flags; the effect of this on the rx_eth() fast
> path is miniscule enough that it should be fine (eg on x86, a cmpb
> instruction becomes a testb instruction).
>
Hi Roland, thanks a lot for finding and fixing this bug.
Cheers,
Divy
prev parent reply other threads:[~2009-01-12 5:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 7:33 [PATCH] cxgb3: Keep LRO off if disabled when interface is down Roland Dreier
2009-01-11 8:19 ` David Miller
2009-01-12 5:10 ` Divy Le Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496AD0DE.2020009@chelsio.com \
--to=divy@chelsio.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).