[PATCH] hso driver fix for big endian machines.

[PATCH] hso driver fix for big endian machines.

[Denis Joseph Barrow]

[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]

Hi there,
This patch is against 2.6.29-rc1 I hope it'll apply to other trees if neccessary.
Filip Aben says this fix is neccessary for big endian machines.

If anybody has one & a hso device & a big endian machine I'd greatly appreciate if you tell me if this
patch works.


A patch needed to make the hso driver work on big endian machines.
Signed-off-by: Denis Joseph Barrow <D.Barow-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
---
Index: linux-2.6/drivers/net/usb/hso.c
===================================================================
--- linux-2.6.orig/drivers/net/usb/hso.c	2009-01-12 15:49:57.000000000 +0100
+++ linux-2.6/drivers/net/usb/hso.c	2009-01-12 15:50:33.000000000 +0100
@@ -1792,8 +1792,8 @@
 
 	/* initialize */
 	ctrl_req->wValue = 0;
-	ctrl_req->wIndex = hso_port_to_mux(port);
-	ctrl_req->wLength = size;
+	ctrl_req->wIndex = cpu_to_le16(hso_port_to_mux(port));
+	ctrl_req->wLength = cpu_to_le16(size);
 
 	if (type == USB_CDC_GET_ENCAPSULATED_RESPONSE) {
 		/* Reading command */

-- 
best regards,
D.J. Barrow

Linux Kernel Developer
Option NV, Gaston Geenslaan 14, 3001 Leuven, Belgium
 
T: +32 16 311 621
F: +32 16 207 164
d.barow-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org
www.option.com

Disclaimer:
http://www.option.com/company/disclaimer.shtml

[-- Attachment #2: hso_big_endian.patch --]
[-- Type: text/x-diff, Size: 727 bytes --]

A patch needed to make the hso driver work on big endian machines.
Signed-off-by: Denis Joseph Barrow <D.Barow-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
---
Index: linux-2.6/drivers/net/usb/hso.c
===================================================================
--- linux-2.6.orig/drivers/net/usb/hso.c	2009-01-12 15:49:57.000000000 +0100
+++ linux-2.6/drivers/net/usb/hso.c	2009-01-12 15:50:33.000000000 +0100
@@ -1792,8 +1792,8 @@
 
 	/* initialize */
 	ctrl_req->wValue = 0;
-	ctrl_req->wIndex = hso_port_to_mux(port);
-	ctrl_req->wLength = size;
+	ctrl_req->wIndex = cpu_to_le16(hso_port_to_mux(port));
+	ctrl_req->wLength = cpu_to_le16(size);
 
 	if (type == USB_CDC_GET_ENCAPSULATED_RESPONSE) {
 		/* Reading command */

Re: [PATCH] hso driver fix for big endian machines.

[Oliver Neukum]

Am Monday 12 January 2009 15:59:10 schrieb Denis Joseph Barrow:
> This patch is against 2.6.29-rc1 I hope it'll apply to other trees if neccessary.
> Filip Aben says this fix is neccessary for big endian machines.

He's correct. They are needed.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hso driver fix for big endian machines.

[David Miller]

From: Oliver Neukum <oliver@neukum.org>
Date: Mon, 12 Jan 2009 16:04:40 +0100

> Am Monday 12 January 2009 15:59:10 schrieb Denis Joseph Barrow:
> > This patch is against 2.6.29-rc1 I hope it'll apply to other trees if neccessary.
> > Filip Aben says this fix is neccessary for big endian machines.
> 
> He's correct. They are needed.

Patch applied, thanks everyone.