netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yongjun <yjwei@cn.fujitsu.com>
To: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH]IPv6:remove duplicate check of optlen when setsockopt with IPV6_PKTINFO option
Date: Wed, 14 Jan 2009 12:07:55 +0800	[thread overview]
Message-ID: <496D651B.2000106@cn.fujitsu.com> (raw)
In-Reply-To: <496D61FE.7080500@cn.fujitsu.com>

Yang Hongyang wrote:
> Herbert Xu wrote:
>   
>> Yang Hongyang <yanghy@cn.fujitsu.com> wrote:
>>     
>>> Actually the condition (optlen == 0) is included in (optlen < sizeof(struct in6_pktinfo)),
>>> so we do not need to check it separately.
>>>       
>> You don't need to check optval == NULL either since that's the
>> job of copy_from_user.
>>     
>
> If optval==NULL, what we should return?EINVAL or EFAULT?
> If it is EINVAL,then we should check it .otherwise it's the job of 
> copy_from_user
>   

I think if optval==NULL, the in6_pktinfo which is set should be remove. 
So, you should handle optval==NULL. Not just return error.

>   
>> Cheers,
>>     
>
>
>   


  reply	other threads:[~2009-01-14  4:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13  7:35 [PATCH]IPv6:remove duplicate check of optlen when setsockopt with IPV6_PKTINFO option Yang Hongyang
2009-01-14  3:47 ` Herbert Xu
2009-01-14  3:54   ` Yang Hongyang
2009-01-14  4:07     ` Wei Yongjun [this message]
2009-01-14  5:27       ` Yang Hongyang
2009-01-14  8:26         ` Shan Wei
2009-01-15  0:50           ` [PATCHv2]IPv6:remove duplicate check " Yang Hongyang
2009-01-14  4:48     ` [PATCH]IPv6:remove duplicate check of optlen " Herbert Xu
2009-01-15  5:02       ` David Miller
2009-01-15  5:04         ` Herbert Xu
2009-01-15  5:06           ` Herbert Xu
2009-01-15  5:25             ` Yang Hongyang
2009-01-15  5:43           ` David Miller
2009-01-15  5:34         ` Yang Hongyang
2009-01-15  5:37           ` Herbert Xu
2009-01-15  5:45             ` David Miller
2009-01-15  5:48               ` Herbert Xu
2009-01-15 10:07               ` Yang Hongyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496D651B.2000106@cn.fujitsu.com \
    --to=yjwei@cn.fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=yanghy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).