netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Hartkopp <oliver@hartkopp.net>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org
Subject: Re: [ANNOUNCE] iproute2 v2.6.28
Date: Fri, 16 Jan 2009 20:06:39 +0100	[thread overview]
Message-ID: <4970DABF.40200@hartkopp.net> (raw)
In-Reply-To: <20090115130845.01d7ebf4@extreme>

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

Stephen Hemminger wrote:
> New version of iproute2 utilities that includes bug fixes and
> support for all the new features in kernel 2.6.28.
>   

Hello Stephen,

your mail reminded me that some defines for the Controller Area Network 
(CAN) are still missing since 2.6.25.

It's not a big problem, but it makes a better show in 'ip link show' on 
CAN interfaces :-)

I also moved __PF(CAN,can) in ll_proto.c to the same position where it 
can be found in if_ether.h .

The only thing i did not know if the __PF(CAN,can) in ll_types.c needs 
to be put in #ifdef ARPHDR_CAN like __PF(HWX25,hwx25) is or not. You 
definitely know that better than me.

Regards,
Oliver


iproute2: add missing defines for Controller Area Network
Signed-off-by: Oliver Hartkopp <oliver@hartkopp.net>



[-- Attachment #2: iproute2-2.6.28-can.patch --]
[-- Type: text/x-patch, Size: 1239 bytes --]

diff -u -r iproute2-2.6.28-orig/ip/ipaddress.c iproute2-2.6.28/ip/ipaddress.c
--- iproute2-2.6.28-orig/ip/ipaddress.c	2009-01-15 21:25:04.000000000 +0100
+++ iproute2-2.6.28/ip/ipaddress.c	2009-01-16 19:33:22.000000000 +0100
@@ -109,6 +109,7 @@
 	_PF(UP);
 	_PF(LOWER_UP);
 	_PF(DORMANT);
+	_PF(ECHO);
 #undef _PF
         if (flags)
 		fprintf(fp, "%x", flags);
diff -u -r iproute2-2.6.28-orig/lib/ll_proto.c iproute2-2.6.28/lib/ll_proto.c
--- iproute2-2.6.28-orig/lib/ll_proto.c	2009-01-15 21:25:04.000000000 +0100
+++ iproute2-2.6.28/lib/ll_proto.c	2009-01-16 19:46:43.000000000 +0100
@@ -84,6 +84,7 @@
 __PF(WAN_PPP,wan_ppp)
 __PF(PPP_MP,ppp_mp)
 __PF(LOCALTALK,localtalk)
+__PF(CAN,can)
 __PF(PPPTALK,ppptalk)
 __PF(TR_802_2,tr_802_2)
 __PF(MOBITEX,mobitex)
@@ -94,7 +95,6 @@
 #endif
 __PF(TIPC,tipc)
 __PF(AOE,aoe)
-__PF(CAN,can)
 
 { 0x8100, "802.1Q" },
 { ETH_P_IP, "ipv4" },
diff -u -r iproute2-2.6.28-orig/lib/ll_types.c iproute2-2.6.28/lib/ll_types.c
--- iproute2-2.6.28-orig/lib/ll_types.c	2009-01-15 21:25:04.000000000 +0100
+++ iproute2-2.6.28/lib/ll_types.c	2009-01-16 19:27:35.000000000 +0100
@@ -70,6 +70,7 @@
 #ifdef ARPHRD_HWX25
 __PF(HWX25,hwx25)
 #endif
+__PF(CAN,can)
 __PF(PPP,ppp)
 __PF(HDLC,hdlc)
 __PF(LAPB,lapb)

      parent reply	other threads:[~2009-01-16 19:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-15 21:08 [ANNOUNCE] iproute2 v2.6.28 Stephen Hemminger
2009-01-16 14:46 ` Arkadiusz Miskiewicz
2009-01-16 17:43   ` Stephen Hemminger
2009-01-16 19:06 ` Oliver Hartkopp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4970DABF.40200@hartkopp.net \
    --to=oliver@hartkopp.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).