From: Pankaj Gupta <pagupta@redhat.com>
To: Cong Wang <cwang@twopensource.com>
Cc: linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>,
"David Miller" <davem@davemloft.net>,
"Jason Wang" <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
dgibson@redhat.com, vfalico@gmail.com,
"Eric Dumazet" <edumazet@google.com>,
"Vladislav Yasevich" <vyasevic@redhat.com>,
"Jerry Chu" <hkchu@google.com>,
wuzhy@redhat.com, "Pavel Emelyanov" <xemul@parallels.com>,
"Tom Herbert" <therbert@google.com>,
bhutchings@solarflare.com, xii@google.com,
"Stephen Hemminger" <stephen@networkplumber.org>,
"Jiří Pírko" <jiri@resnulli.us>,
"sergei shtylyov" <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH net-next 1/4] net: allow large number of rx queues
Date: Thu, 20 Nov 2014 11:31:28 -0500 (EST) [thread overview]
Message-ID: <497267937.1868067.1416501088558.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAHA+R7MnLy=8uL_hSnx=BN2QTs2kvempTxtmSO6hjcS+E0yRwg@mail.gmail.com>
> On Tue, Nov 18, 2014 at 8:22 AM, Pankaj Gupta <pagupta@redhat.com> wrote:
> >
> > As vmalloc() adds overhead on a critical network path,
> > __GFP_REPEAT flag is used with kzalloc() to do this fallback
> > only when really needed.
> >
>
> Are you sure we need __GFP_REPEAT? We have vmalloc() as
> fallback of kmalloc() in many places of networking (grep kvfree),
> none of those I checked has this flag set.
Its there in netif_alloc_netdev_queues() function in same file.
Also, I found it some other places as well.
I think its good to have.
>
next prev parent reply other threads:[~2014-11-20 16:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 16:22 [PATCH net-net 0/4] Increase the limit of tuntap queues Pankaj Gupta
2014-11-18 16:22 ` [PATCH net-next 1/4] net: allow large number of rx queues Pankaj Gupta
2014-11-18 20:29 ` Cong Wang
2014-11-20 16:31 ` Pankaj Gupta [this message]
2014-11-18 16:22 ` [PATCH net-next 2/4] tuntap: Accept tuntap maximum number of queues as sysctl Pankaj Gupta
2014-11-18 16:22 ` [PATCH net-next 3/4] tuntap: reduce the size of tun_struct by using flex array Pankaj Gupta
2014-11-18 16:22 ` [PATCH net-next 4/4] tuntap: Increase the number of queues in tun Pankaj Gupta
2014-11-19 1:43 ` [PATCH net-net 0/4] Increase the limit of tuntap queues Alexei Starovoitov
2014-11-19 20:16 ` David Miller
2014-11-19 20:44 ` Michael S. Tsirkin
2014-11-23 5:22 ` Pankaj Gupta
2014-11-23 10:46 ` Michael S. Tsirkin
2014-11-23 18:43 ` David Miller
2014-11-23 20:30 ` Michael S. Tsirkin
2014-11-24 1:23 ` David Miller
2014-11-24 8:02 ` Michael S. Tsirkin
2014-11-24 14:28 ` Pankaj Gupta
2014-11-24 3:23 ` Jason Wang
2014-11-24 7:55 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497267937.1868067.1416501088558.JavaMail.zimbra@redhat.com \
--to=pagupta@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=dgibson@redhat.com \
--cc=edumazet@google.com \
--cc=hkchu@google.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stephen@networkplumber.org \
--cc=therbert@google.com \
--cc=vfalico@gmail.com \
--cc=vyasevic@redhat.com \
--cc=wuzhy@redhat.com \
--cc=xemul@parallels.com \
--cc=xii@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).