* [PATCH] sctp/ipv6.c: use ipv6_addr_copy
@ 2009-01-22 21:08 Joe Perches
2009-01-22 21:18 ` Vlad Yasevich
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2009-01-22 21:08 UTC (permalink / raw)
To: Sridhar Samudrala, Vlad Yasevich; +Cc: Networking Team, linux-sctp
Signed-off-by: Joe Perches <joe@perches.com>
diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
index ceaa4aa..7862275 100644
--- a/net/sctp/ipv6.c
+++ b/net/sctp/ipv6.c
@@ -97,8 +97,7 @@ static int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
if (addr) {
addr->a.v6.sin6_family = AF_INET6;
addr->a.v6.sin6_port = 0;
- memcpy(&addr->a.v6.sin6_addr, &ifa->addr,
- sizeof(struct in6_addr));
+ ipv6_addr_copy(&addr->a.v6.sin6_addr, &ifa->addr);
addr->a.v6.sin6_scope_id = ifa->idev->dev->ifindex;
addr->valid = 1;
spin_lock_bh(&sctp_local_addr_lock);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] sctp/ipv6.c: use ipv6_addr_copy
2009-01-22 21:08 [PATCH] sctp/ipv6.c: use ipv6_addr_copy Joe Perches
@ 2009-01-22 21:18 ` Vlad Yasevich
2009-01-22 21:50 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Vlad Yasevich @ 2009-01-22 21:18 UTC (permalink / raw)
To: Joe Perches; +Cc: Sridhar Samudrala, Networking Team, linux-sctp
Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
>
> diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> index ceaa4aa..7862275 100644
> --- a/net/sctp/ipv6.c
> +++ b/net/sctp/ipv6.c
> @@ -97,8 +97,7 @@ static int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
> if (addr) {
> addr->a.v6.sin6_family = AF_INET6;
> addr->a.v6.sin6_port = 0;
> - memcpy(&addr->a.v6.sin6_addr, &ifa->addr,
> - sizeof(struct in6_addr));
> + ipv6_addr_copy(&addr->a.v6.sin6_addr, &ifa->addr);
> addr->a.v6.sin6_scope_id = ifa->idev->dev->ifindex;
> addr->valid = 1;
> spin_lock_bh(&sctp_local_addr_lock);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
ACK. Simple enough of a cleanup.
-vlad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-22 21:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-22 21:08 [PATCH] sctp/ipv6.c: use ipv6_addr_copy Joe Perches
2009-01-22 21:18 ` Vlad Yasevich
2009-01-22 21:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).