netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rick Jones <rick.jones2@hp.com>
To: Rick Jones <rick.jones2@hp.com>
Cc: Patrick McHardy <kaber@trash.net>,
	Eric Dumazet <dada1@cosmosbay.com>,
	Linux Network Development list <netdev@vger.kernel.org>,
	Netfilter Developers <netfilter-devel@vger.kernel.org>,
	Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: 32 core net-next stack/netfilter "scaling"
Date: Tue, 27 Jan 2009 11:09:01 -0800	[thread overview]
Message-ID: <497F5BCD.9060807@hp.com> (raw)
In-Reply-To: <497F4C2F.9000804@hp.com>

Rick Jones wrote:
> Patrick McHardy wrote:
> 
>> Eric Dumazet wrote:
>>
>>> [PATCH] netfilter: Get rid of central rwlock in tcp conntracking
>>>
>>> TCP connection tracking suffers of huge contention on a global rwlock,
>>> used to protect tcp conntracking state.
>>>
>>> As each tcp conntrack state have no relations between each others, we
>>> can switch to fine grained lock. Using an array of spinlocks avoids
>>> enlarging size of connection tracking structures, yet giving reasonable
>>> fanout.
>>>
>>> tcp_print_conntrack() doesnt need to lock anything to read
>>> ct->proto.tcp.state, so speedup /proc/net/ip_conntrack as well.
>>>
>>> nf_conntrack_hash_rnd_initted & nf_conntrack_hash_rnd declared 
>>> read_mostly
>>>  
>>
>>
>>
>> This looks good to me. Rick, would you like to give it a try?
>>
>> I'll convert the remaining conntrack protocols when applying it.
> 
> 
> I will give it a try and let folks know the results - unless told 
> otherwise, I will ass-u-me I only need rerun the "full_iptables" test case.

The runemomniagg2.sh script is still running, but the initial cycles profile 
suggests that the main change is converting the write_lock time into spinlock 
contention time with 78.39% of the cycles spent in ia64_spinlock_contention. 
When the script completes I'll upload the profiles and the netperf results to the 
same base URL as in the basenote under "contrack01/"

rick jones

  reply	other threads:[~2009-01-27 19:09 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-26 22:15 32 core net-next stack/netfilter "scaling" Rick Jones
2009-01-26 23:10 ` Eric Dumazet
2009-01-26 23:14   ` Stephen Hemminger
2009-01-26 23:19   ` Rick Jones
2009-01-27  9:10     ` Eric Dumazet
2009-01-27  9:15       ` Patrick McHardy
2009-01-27 11:29         ` Eric Dumazet
2009-01-27 11:37           ` Patrick McHardy
2009-01-27 16:23         ` Eric Dumazet
2009-01-27 17:33           ` Patrick McHardy
2009-01-27 18:02             ` Rick Jones
2009-01-27 19:09               ` Rick Jones [this message]
2009-01-27 19:24                 ` Rick Jones
2009-01-27 22:17                   ` Eric Dumazet
2009-01-27 22:29                     ` Rick Jones
2009-01-27 22:34                       ` Eric Dumazet
2009-01-27 22:43                         ` Rick Jones
2009-01-28 13:55                   ` Eric Dumazet
2009-01-28 16:25                     ` Patrick McHardy
2009-01-28 17:07                       ` Eric Dumazet
2009-01-28 17:34                         ` Eric Dumazet
2009-01-29 15:31                           ` [PATCH] netfilter: unfold two critical loops in ip_packet_match() Eric Dumazet
2009-01-30 15:47                             ` Andi Kleen
2009-01-30 16:54                               ` Eric Dumazet
2009-01-30 17:27                                 ` Andi Kleen
2009-01-30 17:27                                   ` Eric Dumazet
2009-01-30 17:50                                     ` Andi Kleen
2009-02-09 13:41                                   ` Patrick McHardy
2009-02-18 15:10                                     ` Eric Dumazet
2009-02-18 15:21                                       ` Patrick McHardy
2009-02-18 16:33                                         ` Eric Dumazet
2009-02-18 16:52                                           ` Patrick McHardy
2009-02-18 17:36                                           ` [PATCH] netfilter: xt_physdev fixes Eric Dumazet
2009-02-18 18:14                                             ` Patrick McHardy
2009-02-19  8:00                                               ` [PATCH] netfilter: unfold two loops in physdev_mt() Eric Dumazet
2009-02-19  8:14                                                 ` [PATCH] netfilter: unfold two loops in ip6_packet_match() Eric Dumazet
2009-02-19 10:19                                                   ` Patrick McHardy
2009-02-19 10:17                                                 ` [PATCH] netfilter: unfold two loops in physdev_mt() Patrick McHardy
2009-02-20 10:02                             ` [PATCH] netfilter: unfold two critical loops in ip_packet_match() Eric Dumazet
2009-02-20 10:04                               ` Patrick McHardy
2009-02-09 14:57                           ` 32 core net-next stack/netfilter "scaling" Patrick McHardy
2009-02-10 18:44   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=497F5BCD.9060807@hp.com \
    --to=rick.jones2@hp.com \
    --cc=dada1@cosmosbay.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).