[PATCH 2.6.29] cxgb3 - Fix lro switch

[PATCH 2.6.29] cxgb3 - Fix lro switch

[Divy Le Ray]

From: Divy Le Ray <divy@chelsio.com>

The LRO switch is always set to 1 in the rx processing loop.
It breaks the accelerated iSCSI receive traffic.
Fix its computation.

Signed-off-by: Divy Le Ray <divy@chelsio.com>
---

 drivers/net/cxgb3/sge.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/cxgb3/sge.c b/drivers/net/cxgb3/sge.c
index 379a132..d31791f 100644
--- a/drivers/net/cxgb3/sge.c
+++ b/drivers/net/cxgb3/sge.c
@@ -2276,8 +2276,7 @@ no_mem:
 		} else if ((len = ntohl(r->len_cq)) != 0) {
 			struct sge_fl *fl;
 
-			if (eth)
-				lro = qs->lro_enabled && is_eth_tcp(rss_hi);
+			lro &= eth && is_eth_tcp(rss_hi);
 
 			fl = (len & F_RSPD_FLQ) ? &qs->fl[1] : &qs->fl[0];
 			if (fl->use_pages) {

Re: [PATCH 2.6.29] cxgb3 - Fix lro switch

[David Miller]

From: Divy Le Ray <divy@chelsio.com>
Date: Wed, 04 Feb 2009 16:25:47 -0800

> The LRO switch is always set to 1 in the rx processing loop.
> It breaks the accelerated iSCSI receive traffic.
> Fix its computation.
> 
> Signed-off-by: Divy Le Ray <divy@chelsio.com>

Applied, thank you.

Could you slightly reformat your Subject lines for patches?  Please
use something like "cxgb3: $(description)" instead of the "cxgb3 -
$(description)" you're using now.

It'll be one less thing I need to edit when applying your
patches :-)

Thanks!

Re: [PATCH 2.6.29] cxgb3 - Fix lro switch

[Divy Le Ray]

David Miller wrote:
> From: Divy Le Ray <divy@chelsio.com>
> Date: Wed, 04 Feb 2009 16:25:47 -0800
>
>   
>> The LRO switch is always set to 1 in the rx processing loop.
>> It breaks the accelerated iSCSI receive traffic.
>> Fix its computation.
>>
>> Signed-off-by: Divy Le Ray <divy@chelsio.com>
>>     
>
> Applied, thank you.
>
> Could you slightly reformat your Subject lines for patches?  Please
> use something like "cxgb3: $(description)" instead of the "cxgb3 -
> $(description)" you're using now.
>
> It'll be one less thing I need to edit when applying your
> patches :-)
>   

Sorry about that. I'll use this format from now on.

cheers,
Divy