* [PATCH 2.6.29] cxgb3 - Fix lro switch
@ 2009-02-05 0:25 Divy Le Ray
2009-02-05 0:32 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Divy Le Ray @ 2009-02-05 0:25 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, swise, kxie
From: Divy Le Ray <divy@chelsio.com>
The LRO switch is always set to 1 in the rx processing loop.
It breaks the accelerated iSCSI receive traffic.
Fix its computation.
Signed-off-by: Divy Le Ray <divy@chelsio.com>
---
drivers/net/cxgb3/sge.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/cxgb3/sge.c b/drivers/net/cxgb3/sge.c
index 379a132..d31791f 100644
--- a/drivers/net/cxgb3/sge.c
+++ b/drivers/net/cxgb3/sge.c
@@ -2276,8 +2276,7 @@ no_mem:
} else if ((len = ntohl(r->len_cq)) != 0) {
struct sge_fl *fl;
- if (eth)
- lro = qs->lro_enabled && is_eth_tcp(rss_hi);
+ lro &= eth && is_eth_tcp(rss_hi);
fl = (len & F_RSPD_FLQ) ? &qs->fl[1] : &qs->fl[0];
if (fl->use_pages) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2.6.29] cxgb3 - Fix lro switch
2009-02-05 0:25 [PATCH 2.6.29] cxgb3 - Fix lro switch Divy Le Ray
@ 2009-02-05 0:32 ` David Miller
2009-02-05 0:35 ` Divy Le Ray
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2009-02-05 0:32 UTC (permalink / raw)
To: divy; +Cc: netdev, linux-kernel, swise, kxie
From: Divy Le Ray <divy@chelsio.com>
Date: Wed, 04 Feb 2009 16:25:47 -0800
> The LRO switch is always set to 1 in the rx processing loop.
> It breaks the accelerated iSCSI receive traffic.
> Fix its computation.
>
> Signed-off-by: Divy Le Ray <divy@chelsio.com>
Applied, thank you.
Could you slightly reformat your Subject lines for patches? Please
use something like "cxgb3: $(description)" instead of the "cxgb3 -
$(description)" you're using now.
It'll be one less thing I need to edit when applying your
patches :-)
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2.6.29] cxgb3 - Fix lro switch
2009-02-05 0:32 ` David Miller
@ 2009-02-05 0:35 ` Divy Le Ray
0 siblings, 0 replies; 3+ messages in thread
From: Divy Le Ray @ 2009-02-05 0:35 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-kernel, swise, kxie
David Miller wrote:
> From: Divy Le Ray <divy@chelsio.com>
> Date: Wed, 04 Feb 2009 16:25:47 -0800
>
>
>> The LRO switch is always set to 1 in the rx processing loop.
>> It breaks the accelerated iSCSI receive traffic.
>> Fix its computation.
>>
>> Signed-off-by: Divy Le Ray <divy@chelsio.com>
>>
>
> Applied, thank you.
>
> Could you slightly reformat your Subject lines for patches? Please
> use something like "cxgb3: $(description)" instead of the "cxgb3 -
> $(description)" you're using now.
>
> It'll be one less thing I need to edit when applying your
> patches :-)
>
Sorry about that. I'll use this format from now on.
cheers,
Divy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-05 0:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-05 0:25 [PATCH 2.6.29] cxgb3 - Fix lro switch Divy Le Ray
2009-02-05 0:32 ` David Miller
2009-02-05 0:35 ` Divy Le Ray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).