From: Roel Kluin <roel.kluin@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] netdevice: ticks reaches 25, not 26.
Date: Mon, 09 Feb 2009 23:22:11 +0100 [thread overview]
Message-ID: <4990AC93.3080906@gmail.com> (raw)
With while (tick++ < 25) { ... } ticks reaches 25, not 26.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/myri_sbus.c b/drivers/net/myri_sbus.c
index 899ed06..a95e217 100644
--- a/drivers/net/myri_sbus.c
+++ b/drivers/net/myri_sbus.c
@@ -161,7 +161,7 @@ static int myri_do_handshake(struct myri_eth *mp)
myri_enable_irq(mp->lregs, cregs);
- if (tick > 25) {
+ if (tick >= 25) {
DET(("25 ticks we lose, failure.\n"));
return -1;
}
next reply other threads:[~2009-02-09 22:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 22:22 Roel Kluin [this message]
2009-02-10 1:57 ` [PATCH] netdevice: ticks reaches 25, not 26 David Miller
2009-02-10 8:50 ` Jarek Poplawski
2009-02-10 8:59 ` David Miller
2009-02-10 9:19 ` Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4990AC93.3080906@gmail.com \
--to=roel.kluin@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).