* [PATCH] sun3: print when lance_open() fails
@ 2009-02-11 15:14 Roel Kluin
2009-02-13 0:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-02-11 15:14 UTC (permalink / raw)
To: sammy; +Cc: netdev, Andrew Morton
With while (--i > 0) { ... } i reaches 0; print when lance_open() fails
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/sun3lance.c b/drivers/net/sun3lance.c
index 4bb8f72..e5beb29 100644
--- a/drivers/net/sun3lance.c
+++ b/drivers/net/sun3lance.c
@@ -428,7 +428,7 @@ static int lance_open( struct net_device *dev )
while (--i > 0)
if (DREG & CSR0_IDON)
break;
- if (i < 0 || (DREG & CSR0_ERR)) {
+ if (i <= 0 || (DREG & CSR0_ERR)) {
DPRINTK( 2, ( "lance_open(): opening %s failed, i=%d, csr0=%04x\n",
dev->name, i, DREG ));
DREG = CSR0_STOP;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sun3: print when lance_open() fails
2009-02-11 15:14 [PATCH] sun3: print when lance_open() fails Roel Kluin
@ 2009-02-13 0:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-02-13 0:40 UTC (permalink / raw)
To: roel.kluin; +Cc: sammy, netdev, akpm
From: Roel Kluin <roel.kluin@gmail.com>
Date: Wed, 11 Feb 2009 16:14:09 +0100
> With while (--i > 0) { ... } i reaches 0; print when lance_open() fails
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-13 0:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-11 15:14 [PATCH] sun3: print when lance_open() fails Roel Kluin
2009-02-13 0:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).