[PATCH]netxen:fix compile waring "label ‘set_32_bit_mask’ defined but not used" on IA64 platform

[PATCH]netxen:fix compile waring "label ‘set_32_bit_mask’ defined but not used" on IA64 platform

[Yang Hongyang]

When compile the latest kernel on IA64 platform,I got a warning:
drivers/net/netxen/netxen_nic_main.c:203: warning: label ‘set_32_bit_mask’ 
defined but not used

We do not need label ‘set_32_bit_mask’  on IA64 platform,So move it to #else.

Signed-off-by: Yang Hongyang<yanghy@cn.fujitsu.com>

---
 drivers/net/netxen/netxen_nic_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index 3b17a79..b0ac5d6 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -201,9 +201,9 @@ static int nx_set_dma_mask(struct netxen_adapter *adapter, uint8_t revision_id)
 		adapter->pci_using_dac = 1;
 		return 0;
 	}
+set_32_bit_mask:
 #endif /* CONFIG_IA64 */
 
-set_32_bit_mask:
 	err = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
 	if (!err)
 		err = pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK);
-- 
1.6.0.3


-- 
Regards
Yang Hongyang

Re: [PATCH]netxen:fix compile waring "label ‘set_32_bit_mask’ defined but not used" on IA64 platform

[David Miller]

From: Yang Hongyang <yanghy@cn.fujitsu.com>
Date: Thu, 12 Feb 2009 16:03:51 +0800

> When compile the latest kernel on IA64 platform,I got a warning:
> drivers/net/netxen/netxen_nic_main.c:203: warning: label ‘set_32_bit_mask’ 
> defined but not used
> 
> We do not need label ‘set_32_bit_mask’  on IA64 platform,So move it to #else.
> 
> Signed-off-by: Yang Hongyang<yanghy@cn.fujitsu.com>

Applied.

Although I think this whole CONFIG_IA64 ifdef business should
be eliminated entirely.  You cannot tell me that we don't
have the generic interfaces necessary to make a proper
decision on dma mask selection in this bit of code.