From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [RFC] netlink broadcast return value Date: Thu, 12 Feb 2009 13:48:09 +0100 Message-ID: <49941A89.80606@trash.net> References: <4985A4C5.4050908@netfilter.org> <20090202.140533.121159038.davem@davemloft.net> <49903B03.2040302@trash.net> <4990B38A.3020207@netfilter.org> <4990BADA.7040309@trash.net> <4990C337.3040704@netfilter.org> <4991863F.3030800@trash.net> <4991CCC1.7080308@netfilter.org> <4992C827.20302@trash.net> <4992FF51.9010507@netfilter.org> <499302E0.4070406@trash.net> <49933CBE.8010108@netfilter.org> <4993AE94.1000104@trash.net> <499417E3.5010304@netfilter.org> <499418F2.8070008@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org To: Pablo Neira Ayuso Return-path: Received: from stinky.trash.net ([213.144.137.162]:49013 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761112AbZBLMsN (ORCPT ); Thu, 12 Feb 2009 07:48:13 -0500 In-Reply-To: <499418F2.8070008@netfilter.org> Sender: netdev-owner@vger.kernel.org List-ID: Pablo Neira Ayuso wrote: > Oh, and also for this: > >> if (p->skb2 == NULL) { >> netlink_overrun(sk); >> /* Clone failed. Notify ALL listeners. */ >> p->failure = 1; > ^^^^^^^^^^^^^^^ > > if (nlk->flags & NETLINK_HIGHLY_RELIABLE) > p->failure = 1; I always wondered about the intention behind this. It wouldn't hurt to just try the other allocation and see if they also fail.