From: Jiri Slaby <jirislaby@gmail.com>
To: Hannes Eder <hannes@hanneseder.net>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/isdn/hardware/mISDN: change type of hfc_jiffies to ulong
Date: Sat, 14 Feb 2009 23:48:58 +0100 [thread overview]
Message-ID: <49974A5A.9030109@gmail.com> (raw)
In-Reply-To: <20090214224049.28194.38982.stgit@vmbox.hanneseder.net>
Hannes Eder wrote:
> Patch suggested by Jiri Slaby.
Well, at least some log needed.
jiffies are ulong, make sure we fit in jiffies store variable on archs with
bits per long > 32.
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
> ---
>
> This patch is based on:
> drivers/isdn/hardware/mISDN: fix sparse warnings: make symbols static
>
> drivers/isdn/hardware/mISDN/hfcpci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
> index 2bb85c4..c7a855c 100644
> --- a/drivers/isdn/hardware/mISDN/hfcpci.c
> +++ b/drivers/isdn/hardware/mISDN/hfcpci.c
> @@ -57,7 +57,7 @@ static int HFC_cnt;
> static uint debug;
> static uint poll, tics;
> static struct timer_list hfc_tl;
> -static u32 hfc_jiffies;
> +static ulong hfc_jiffies;
Ok, unsigned long would be nicer. I though it would be implicit when writing
about ulong, but I see not in this uint-et-al context...
prev parent reply other threads:[~2009-02-14 22:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 22:44 [PATCH] drivers/isdn/hardware/mISDN: change type of hfc_jiffies to ulong Hannes Eder
2009-02-14 22:48 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49974A5A.9030109@gmail.com \
--to=jirislaby@gmail.com \
--cc=hannes@hanneseder.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).