netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/isdn/hardware/mISDN: change type of hfc_jiffies to ulong
@ 2009-02-14 22:44 Hannes Eder
  2009-02-14 22:48 ` Jiri Slaby
  0 siblings, 1 reply; 2+ messages in thread
From: Hannes Eder @ 2009-02-14 22:44 UTC (permalink / raw)
  To: netdev; +Cc: kernel-janitors, linux-kernel, Jiri Slaby

Patch suggested by Jiri Slaby.

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---

This patch is based on:
    drivers/isdn/hardware/mISDN: fix sparse warnings: make symbols static

 drivers/isdn/hardware/mISDN/hfcpci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
index 2bb85c4..c7a855c 100644
--- a/drivers/isdn/hardware/mISDN/hfcpci.c
+++ b/drivers/isdn/hardware/mISDN/hfcpci.c
@@ -57,7 +57,7 @@ static int HFC_cnt;
 static uint debug;
 static uint poll, tics;
 static struct timer_list hfc_tl;
-static u32 hfc_jiffies;
+static ulong hfc_jiffies;
 
 MODULE_AUTHOR("Karsten Keil");
 MODULE_LICENSE("GPL");


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/isdn/hardware/mISDN: change type of hfc_jiffies to ulong
  2009-02-14 22:44 [PATCH] drivers/isdn/hardware/mISDN: change type of hfc_jiffies to ulong Hannes Eder
@ 2009-02-14 22:48 ` Jiri Slaby
  0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2009-02-14 22:48 UTC (permalink / raw)
  To: Hannes Eder; +Cc: netdev, kernel-janitors, linux-kernel

Hannes Eder wrote:
> Patch suggested by Jiri Slaby.

Well, at least some log needed.

jiffies are ulong, make sure we fit in jiffies store variable on archs with
bits per long > 32.

> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
> ---
> 
> This patch is based on:
>     drivers/isdn/hardware/mISDN: fix sparse warnings: make symbols static
> 
>  drivers/isdn/hardware/mISDN/hfcpci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
> index 2bb85c4..c7a855c 100644
> --- a/drivers/isdn/hardware/mISDN/hfcpci.c
> +++ b/drivers/isdn/hardware/mISDN/hfcpci.c
> @@ -57,7 +57,7 @@ static int HFC_cnt;
>  static uint debug;
>  static uint poll, tics;
>  static struct timer_list hfc_tl;
> -static u32 hfc_jiffies;
> +static ulong hfc_jiffies;

Ok, unsigned long would be nicer. I though it would be implicit when writing
about ulong, but I see not in this uint-et-al context...

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-02-14 22:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-14 22:44 [PATCH] drivers/isdn/hardware/mISDN: change type of hfc_jiffies to ulong Hannes Eder
2009-02-14 22:48 ` Jiri Slaby

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).