netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tg3: fix typo && -> || in drivers/net/tg3.c
@ 2009-02-17  6:19 Wei Yongjun
  2009-02-19  1:44 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2009-02-17  6:19 UTC (permalink / raw)
  To: Michael Chan, netdev

Fix the typo && -> ||

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
 drivers/net/tg3.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 4595962..b080f94 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -2237,8 +2237,8 @@ static int tg3_set_power_state(struct tg3 *tp, pci_power_t state)
 			phyid = phydev->drv->phy_id & phydev->drv->phy_id_mask;
 			if (phyid != TG3_PHY_ID_BCMAC131) {
 				phyid &= TG3_PHY_OUI_MASK;
-				if (phyid == TG3_PHY_OUI_1 &&
-				    phyid == TG3_PHY_OUI_2 &&
+				if (phyid == TG3_PHY_OUI_1 ||
+				    phyid == TG3_PHY_OUI_2 ||
 				    phyid == TG3_PHY_OUI_3)
 					do_low_power = true;
 			}
-- 
1.5.3.8





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tg3: fix typo && -> || in drivers/net/tg3.c
  2009-02-17  6:19 [PATCH] tg3: fix typo && -> || in drivers/net/tg3.c Wei Yongjun
@ 2009-02-19  1:44 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-02-19  1:44 UTC (permalink / raw)
  To: yjwei; +Cc: mchan, netdev

From: Wei Yongjun <yjwei@cn.fujitsu.com>
Date: Tue, 17 Feb 2009 14:19:24 +0800

> Fix the typo && -> ||
> 
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>

Roel Kluin already posted a fix for this, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-02-19  1:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-17  6:19 [PATCH] tg3: fix typo && -> || in drivers/net/tg3.c Wei Yongjun
2009-02-19  1:44 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).