From: Roel Kluin <roel.kluin@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: chas3@users.sourceforge.net, netdev@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] ATM: misplaced parentheses?
Date: Tue, 17 Feb 2009 10:59:36 +0100 [thread overview]
Message-ID: <499A8A88.2070300@gmail.com> (raw)
In-Reply-To: <20090216223001.GW28946@ZenIV.linux.org.uk>
Al Viro wrote:
> while you technically only need parens around ?:, in this case it's
> better to keep it fully parenthesised - more readable that way.
>
> The lack of parens around ?: in the current tree is an obvious bug.
Ok, with extra for clarity:
-------------------------->8------------------8<---------------------------
Add missing parentheses
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c
index 144a49f..8733a2e 100644
--- a/drivers/atm/lanai.c
+++ b/drivers/atm/lanai.c
@@ -901,7 +901,7 @@ static int __devinit eeprom_read(struct lanai_dev *lanai)
clock_l(); udelay(5);
for (i = 128; i != 0; i >>= 1) { /* write command out */
tmp = (lanai->conf1 & ~CONFIG1_PROMDATA) |
- (data & i) ? CONFIG1_PROMDATA : 0;
+ ((data & i) ? CONFIG1_PROMDATA : 0);
if (lanai->conf1 != tmp) {
set_config1(tmp);
udelay(5); /* Let new data settle */
next prev parent reply other threads:[~2009-02-17 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 16:07 [PATCH] ATM: misplaced parentheses? Roel Kluin
2009-02-16 22:02 ` Chas Williams (CONTRACTOR)
2009-02-16 22:30 ` Al Viro
2009-02-17 9:59 ` Roel Kluin [this message]
2009-02-19 1:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499A8A88.2070300@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chas3@users.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).