* [PATCH] sundance: missing parentheses?
@ 2009-02-18 9:19 Roel Kluin
2009-02-20 8:36 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-02-18 9:19 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, Andrew Morton
Please review.
--------------------------->8-------------8<------------------------------
Add missing parentheses
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/sundance.c b/drivers/net/sundance.c
index feaf0e0..43695b7 100644
--- a/drivers/net/sundance.c
+++ b/drivers/net/sundance.c
@@ -909,7 +909,7 @@ static void check_duplex(struct net_device *dev)
printk(KERN_INFO "%s: Setting %s-duplex based on MII #%d "
"negotiated capability %4.4x.\n", dev->name,
duplex ? "full" : "half", np->phys[0], negotiated);
- iowrite16(ioread16(ioaddr + MACCtrl0) | duplex ? 0x20 : 0, ioaddr + MACCtrl0);
+ iowrite16(ioread16(ioaddr + MACCtrl0) | (duplex ? 0x20 : 0), ioaddr + MACCtrl0);
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sundance: missing parentheses?
2009-02-18 9:19 [PATCH] sundance: missing parentheses? Roel Kluin
@ 2009-02-20 8:36 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-02-20 8:36 UTC (permalink / raw)
To: roel.kluin; +Cc: jgarzik, netdev, akpm
From: Roel Kluin <roel.kluin@gmail.com>
Date: Wed, 18 Feb 2009 10:19:50 +0100
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-20 8:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-18 9:19 [PATCH] sundance: missing parentheses? Roel Kluin
2009-02-20 8:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).