From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: [PATCH] RDMA/cxgb3: logical-/bit-or confusion? Date: Wed, 18 Feb 2009 09:13:48 -0600 Message-ID: <499C25AC.6090409@opengridcomputing.com> References: <499BD470.4080705@gmail.com> <499C0143.1080703@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Andrew Morton , "David S. Miller" , netdev@vger.kernel.org To: Roel Kluin Return-path: Received: from smtp.opengridcomputing.com ([209.198.142.2]:51390 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbZBRPNm (ORCPT ); Wed, 18 Feb 2009 10:13:42 -0500 In-Reply-To: <499C0143.1080703@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Reviewed-by: Steve Wise Roel Kluin wrote: > Dropped general@lists.openfabrics.org since it bounces, and I missed one > in my previously sent patch > --------------------------->8-------------8<------------------------------ > Logical-/bit-or typo > > Signed-off-by: Roel Kluin > --- > diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c > index 44e936e..21c6145 100644 > --- a/drivers/infiniband/hw/cxgb3/iwch_cm.c > +++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c > @@ -890,7 +890,7 @@ static void process_mpa_reply(struct iwch_ep *ep, struct sk_buff *skb) > */ > state_set(&ep->com, FPDU_MODE); > ep->mpa_attr.initiator = 1; > - ep->mpa_attr.crc_enabled = (mpa->flags & MPA_CRC) | crc_enabled ? 1 : 0; > + ep->mpa_attr.crc_enabled = (mpa->flags & MPA_CRC) || crc_enabled ? 1 : 0; > ep->mpa_attr.recv_marker_enabled = markers_enabled; > ep->mpa_attr.xmit_marker_enabled = mpa->flags & MPA_MARKERS ? 1 : 0; > ep->mpa_attr.version = mpa_rev; > @@ -1013,7 +1013,7 @@ static void process_mpa_request(struct iwch_ep *ep, struct sk_buff *skb) > * start reply message including private data. > */ > ep->mpa_attr.initiator = 0; > - ep->mpa_attr.crc_enabled = (mpa->flags & MPA_CRC) | crc_enabled ? 1 : 0; > + ep->mpa_attr.crc_enabled = (mpa->flags & MPA_CRC) || crc_enabled ? 1 : 0; > ep->mpa_attr.recv_marker_enabled = markers_enabled; > ep->mpa_attr.xmit_marker_enabled = mpa->flags & MPA_MARKERS ? 1 : 0; > ep->mpa_attr.version = mpa_rev; > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >