netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Ceuleers <jan.ceuleers@computer.org>
To: netdev@vger.kernel.org
Subject: via-velocity: printk of dev->name before name has been allocated
Date: Sat, 21 Feb 2009 19:56:11 +0100	[thread overview]
Message-ID: <49A04E4B.7080207@computer.org> (raw)

I have the following in dmesg:

[   21.212838] VIA Networking Velocity Family Gigabit Ethernet Adapter 
Driver Ver. 1.14
[   21.212847] Copyright (c) 2002, 2003 VIA Networking Technologies, Inc.
[   21.212852] Copyright (c) 2004 Red Hat Inc.
[   21.212885] ACPI: PCI Interrupt 0000:00:0e.0[A] -> GSI 18 (level, 
low) -> IRQ 17
[   21.212937] eth%d: set value of parameter Interrupt service works to 64
[   21.213684] eth0: VIA Networking Velocity Family Gigabit Ethernet Adapter
[   21.213691] eth0: Ethernet Address: 00:40:63:F4:AF:DE

The notification that the module parameter has been taken into account 
is output before the device name has been allocated. This is with the 
following kernel version:

Linux fe2 2.6.22-16-generic #1 SMP Mon Jan 26 00:07:52 GMT 2009 i686 
GNU/Linux

which is quite "old", but when I looked at current git net-2.6 I think 
that this problem is still there.

I think that the cause is that in velocity_found1(), 
velocity_get_pci_info() is called (which outputs the "set value of 
parameter" message) before register_netdev() is (which I think allocates 
the device name).

I'm afraid I'm incapable of fixing this cosmetic problem myself; perhaps 
one of you kind folk can.

Thanks, Jan


             reply	other threads:[~2009-02-21 18:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-21 18:56 Jan Ceuleers [this message]
2009-02-22  7:51 ` via-velocity: printk of dev->name before name has been allocated David Miller
2009-02-22  8:43   ` Jan Ceuleers
2009-02-22 10:33     ` David Miller
2009-02-22 10:44       ` Jan Ceuleers
2009-02-22 11:23         ` David Miller
2009-02-22 11:08   ` Jan Ceuleers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A04E4B.7080207@computer.org \
    --to=jan.ceuleers@computer.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).