* !CONFIG_NET_NS build error, net/core/net_namespace.c
@ 2009-02-24 13:00 Mike Galbraith
2009-02-24 13:43 ` Daniel Lezcano
0 siblings, 1 reply; 2+ messages in thread
From: Mike Galbraith @ 2009-02-24 13:00 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: David Miller, netdev, LKML
CC net/core/net_namespace.o
net/core/net_namespace.c: In function ‘net_ns_init’:
net/core/net_namespace.c:223: error: implicit declaration of function ‘net_alloc_generic’
net/core/net_namespace.c:223: warning: assignment makes pointer from integer without a cast
make[2]: *** [net/core/net_namespace.o] Error 1
make[1]: *** [net/core] Error 2
make: *** [net] Error 2
Impact: fix !CONFIG_NET_NS net/core/net_namespace.c build error
Signed-off-by: Mike Galbraith <efault@gmx.de>
net/core/net_namespace.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
index b0767ab..2adb1a7 100644
--- a/net/core/net_namespace.c
+++ b/net/core/net_namespace.c
@@ -63,10 +63,6 @@ out_undo:
goto out;
}
-#ifdef CONFIG_NET_NS
-static struct kmem_cache *net_cachep;
-static struct workqueue_struct *netns_wq;
-
static struct net_generic *net_alloc_generic(void)
{
struct net_generic *ng;
@@ -80,6 +76,10 @@ static struct net_generic *net_alloc_generic(void)
return ng;
}
+#ifdef CONFIG_NET_NS
+static struct kmem_cache *net_cachep;
+static struct workqueue_struct *netns_wq;
+
static struct net *net_alloc(void)
{
struct net *net = NULL;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: !CONFIG_NET_NS build error, net/core/net_namespace.c
2009-02-24 13:00 !CONFIG_NET_NS build error, net/core/net_namespace.c Mike Galbraith
@ 2009-02-24 13:43 ` Daniel Lezcano
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2009-02-24 13:43 UTC (permalink / raw)
To: Mike Galbraith; +Cc: David Miller, netdev, LKML
Mike Galbraith wrote:
> CC net/core/net_namespace.o
> net/core/net_namespace.c: In function ‘net_ns_init’:
> net/core/net_namespace.c:223: error: implicit declaration of function ‘net_alloc_generic’
> net/core/net_namespace.c:223: warning: assignment makes pointer from integer without a cast
> make[2]: *** [net/core/net_namespace.o] Error 1
> make[1]: *** [net/core] Error 2
> make: *** [net] Error 2
>
>
Thanks, this has been fixed with commit
ebe47d47b7b7fed72dabcce4717da727b4e2367d
Sorry for the inconvenience.
-- Daniel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-24 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-24 13:00 !CONFIG_NET_NS build error, net/core/net_namespace.c Mike Galbraith
2009-02-24 13:43 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).