netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] packet: remove some pointless conditionals before kfree_skb()
@ 2009-02-25 10:36 Wei Yongjun
  2009-02-27  7:09 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2009-02-25 10:36 UTC (permalink / raw)
  To: David Miller; +Cc: netdev

Remove some pointless conditionals before kfree_skb().

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
 net/packet/af_packet.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 1fc4a78..d8cc006 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -756,8 +756,7 @@ ring_is_full:
 	spin_unlock(&sk->sk_receive_queue.lock);
 
 	sk->sk_data_ready(sk, 0);
-	if (copy_skb)
-		kfree_skb(copy_skb);
+	kfree_skb(copy_skb);
 	goto drop_n_restore;
 }
 
-- 
1.5.3.8





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] packet: remove some pointless conditionals before kfree_skb()
  2009-02-25 10:36 [PATCH] packet: remove some pointless conditionals before kfree_skb() Wei Yongjun
@ 2009-02-27  7:09 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-02-27  7:09 UTC (permalink / raw)
  To: yjwei; +Cc: netdev

From: Wei Yongjun <yjwei@cn.fujitsu.com>
Date: Wed, 25 Feb 2009 18:36:42 +0800

> Remove some pointless conditionals before kfree_skb().
> 
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-02-27  7:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-25 10:36 [PATCH] packet: remove some pointless conditionals before kfree_skb() Wei Yongjun
2009-02-27  7:09 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).