* [PATCH] llc: remove some pointless conditionals before kfree_skb()
@ 2009-02-25 10:42 Wei Yongjun
2009-02-27 7:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2009-02-25 10:42 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: netdev
Remove some pointless conditionals before kfree_skb().
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
net/llc/llc_conn.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/llc/llc_conn.c b/net/llc/llc_conn.c
index 5c6d89c..3477624 100644
--- a/net/llc/llc_conn.c
+++ b/net/llc/llc_conn.c
@@ -332,8 +332,7 @@ int llc_conn_remove_acked_pdus(struct sock *sk, u8 nr, u16 *how_many_unacked)
for (i = 0; i < pdu_pos && i < q_len; i++) {
skb = skb_dequeue(&llc->pdu_unack_q);
- if (skb)
- kfree_skb(skb);
+ kfree_skb(skb);
nbr_acked++;
}
out:
--
1.5.3.8
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] llc: remove some pointless conditionals before kfree_skb()
2009-02-25 10:42 [PATCH] llc: remove some pointless conditionals before kfree_skb() Wei Yongjun
@ 2009-02-27 7:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-02-27 7:09 UTC (permalink / raw)
To: yjwei; +Cc: acme, netdev
From: Wei Yongjun <yjwei@cn.fujitsu.com>
Date: Wed, 25 Feb 2009 18:42:22 +0800
> Remove some pointless conditionals before kfree_skb().
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-27 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-25 10:42 [PATCH] llc: remove some pointless conditionals before kfree_skb() Wei Yongjun
2009-02-27 7:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).