* [PATCH] sungem: another error printed one too early
@ 2009-02-16 14:02 Roel Kluin
2009-02-26 12:55 ` Roel Kluin
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2009-02-16 14:02 UTC (permalink / raw)
To: David S. Miller; +Cc: Daniel Walker, netdev, Andrew Morton
Another error was printed one too early.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/sungem.c b/drivers/net/sungem.c
index 4918763..8d64b1d 100644
--- a/drivers/net/sungem.c
+++ b/drivers/net/sungem.c
@@ -1157,7 +1157,7 @@ static void gem_pcs_reset(struct gem *gp)
if (limit-- <= 0)
break;
}
- if (limit <= 0)
+ if (limit < 0)
printk(KERN_WARNING "%s: PCS reset bit would not clear.\n",
gp->dev->name);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sungem: another error printed one too early
2009-02-16 14:02 [PATCH] sungem: another error printed one too early Roel Kluin
@ 2009-02-26 12:55 ` Roel Kluin
2009-03-04 8:08 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2009-02-26 12:55 UTC (permalink / raw)
To: David S. Miller; +Cc: Daniel Walker, netdev, Andrew Morton
Roel Kluin wrote:
> Another error was printed one too early.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
I am not sure why my script didn't report this earlier.
-----------------------------------------------------
Another error was printed one too early.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/sungem.c b/drivers/net/sungem.c
index 8d64b1d..0fcb750 100644
--- a/drivers/net/sungem.c
+++ b/drivers/net/sungem.c
@@ -1229,7 +1229,7 @@ static void gem_reset(struct gem *gp)
break;
} while (val & (GREG_SWRST_TXRST | GREG_SWRST_RXRST));
- if (limit <= 0)
+ if (limit < 0)
printk(KERN_ERR "%s: SW reset is ghetto.\n", gp->dev->name);
if (gp->phy_type == phy_serialink || gp->phy_type == phy_serdes)
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-04 8:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-16 14:02 [PATCH] sungem: another error printed one too early Roel Kluin
2009-02-26 12:55 ` Roel Kluin
2009-03-04 8:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).