netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Ben Greear <greearb@candelatech.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Linux Netdev List <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: IPv4/IPv6 sysctl unregistration deadlock
Date: Mon, 02 Mar 2009 23:20:49 +0100	[thread overview]
Message-ID: <49AC5BC1.3030901@trash.net> (raw)
In-Reply-To: <49AC597B.4090404@candelatech.com>

Ben Greear wrote:
> With both of Stephen's patches included in the latest -rc6 source,
> I re-ran the test and it seems to be working (I added printks so
> that I would know the new code was being exercise
> 
> I had 2000 or so mac-vlans configured, with 10 of them being
> re-configured concurrently, while also deleting groups of 20-100
> mac-vlans in my test.  This was locking up reliably before,
> and now it seems to be working fine.
> 
> Here's the kernel log showing the ERESTARTSYS in action.  I don't
> have an easy way to check to see if the VFS (or whatever) retried
> the call properly, but will let you all know if I see any indication
> that isn't working.
> 
> I only saw the ipv6 fixup in my logs, but maybe my test case just
> doesn't hit the other...

This looks like its working fine. Despite the non-desirable active
spinning, this seems like the best fix (actually much simpler than
I expected to be possible) at this time. If we just could avoid
the spinning when unnecessary, it would be perfect :)

  reply	other threads:[~2009-03-02 22:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25  5:23 IPv4/IPv6 sysctl unregistration deadlock Patrick McHardy
2009-02-25  6:19 ` Herbert Xu
2009-02-25  6:23   ` Patrick McHardy
2009-02-25  7:18     ` Patrick McHardy
2009-02-25  8:43       ` Herbert Xu
2009-02-26  6:06         ` Eric W. Biederman
2009-02-26  6:10         ` Eric W. Biederman
2009-02-26  6:22           ` Herbert Xu
2009-02-26  7:18             ` Eric W. Biederman
2009-02-26 16:49               ` Stephen Hemminger
2009-02-26 19:01                 ` Eric W. Biederman
2009-02-26 20:24                   ` Stephen Hemminger
2009-02-27  0:59                 ` Herbert Xu
2009-02-27  1:25                   ` Stephen Hemminger
2009-02-27 18:26                 ` Ben Greear
2009-02-27 18:38                   ` Stephen Hemminger
2009-03-02 11:07                     ` Patrick McHardy
2009-03-02 11:21                       ` Patrick McHardy
2009-03-02 22:11                     ` Ben Greear
2009-03-02 22:20                       ` Patrick McHardy [this message]
2009-03-02 22:47                         ` David Miller
2009-03-02 23:03                           ` Patrick McHardy
2009-03-03  8:48                             ` David Miller
2009-03-08  3:36                               ` Eric W. Biederman
2009-02-26 16:55       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49AC5BC1.3030901@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=greearb@candelatech.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).