From: Patrick McHardy <kaber@trash.net>
To: Bart Trojanowski <bart@jukie.net>
Cc: David Miller <davem@davemloft.net>,
greearb@candelatech.com, shemminger@vyatta.com,
dada1@cosmosbay.com, frank.blaschka@de.ibm.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG] 2.6.29-rc* QinQ vlan trunking regression
Date: Thu, 05 Mar 2009 06:51:57 +0100 [thread overview]
Message-ID: <49AF687D.9080708@trash.net> (raw)
In-Reply-To: <20090305045925.GG5959@jukie.net>
Bart Trojanowski wrote:
>>> As analyzed by Patrick McHardy, vlan needs to reset it's
>>> netdev_ops pointer in it's ->init() function but this
>>> leaves the compat method pointers stale.
>>>
>>> Add a netdev_resync_ops() and call it from the vlan code.
>> <snip>
>>> include/linux/netdevice.h | 1 +
>>> net/8021q/vlan_dev.c | 1 +
>>> net/core/dev.c | 54 +++++++++++++++++++++++++++-----------------
>>> 3 files changed, 35 insertions(+), 21 deletions(-)
>> I tried this patch onto v2.6.29-rc7-3-g559595a, but I still get a crash.
>> I assume that this worked for you, so I am not putting much faith in my
>> results at this late hour. I'll confirm tomorrow morning that it's not
>> something else.
>
> ... if you're interested, here is the Oops. And like I said, I'll
> retest tomorrow.
Thanks, I'll try to reproduce it here.
next prev parent reply other threads:[~2009-03-05 5:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-28 18:05 [BUG] 2.6.29-rc* QinQ vlan trunking regression Bart Trojanowski
2009-03-04 7:43 ` David Miller
2009-03-04 9:57 ` Patrick McHardy
2009-03-04 10:59 ` David Miller
2009-03-04 11:45 ` Patrick McHardy
2009-03-05 3:53 ` David Miller
2009-03-05 4:54 ` Bart Trojanowski
2009-03-05 4:59 ` Bart Trojanowski
2009-03-05 5:51 ` Patrick McHardy [this message]
2009-03-05 5:21 ` David Miller
2009-03-05 5:51 ` Patrick McHardy
2009-03-05 6:57 ` David Miller
2009-03-05 7:00 ` David Miller
2009-03-05 7:05 ` Patrick McHardy
2009-03-05 7:11 ` David Miller
2009-03-05 7:12 ` Patrick McHardy
2009-03-05 7:19 ` David Miller
2009-03-05 7:26 ` Patrick McHardy
2009-03-05 7:31 ` Patrick McHardy
2009-03-05 7:45 ` David Miller
2009-03-05 8:05 ` Frank Blaschka
2009-03-05 8:27 ` Patrick McHardy
2009-03-05 8:56 ` David Miller
2009-03-05 8:59 ` David Miller
2009-03-05 9:08 ` Patrick McHardy
2009-03-05 9:09 ` Patrick McHardy
2009-03-05 9:58 ` David Miller
2009-03-05 12:30 ` Maxime Bizon
2009-03-05 12:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AF687D.9080708@trash.net \
--to=kaber@trash.net \
--cc=bart@jukie.net \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=frank.blaschka@de.ibm.com \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).