From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [BUG] 2.6.29-rc* QinQ vlan trunking regression Date: Thu, 05 Mar 2009 06:51:57 +0100 Message-ID: <49AF687D.9080708@trash.net> References: <49AE509B.3000305@trash.net> <20090304.025914.149394356.davem@davemloft.net> <49AE69DD.80802@trash.net> <20090304.195328.106253933.davem@davemloft.net> <20090305045442.GF5959@jukie.net> <20090305045925.GG5959@jukie.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , greearb@candelatech.com, shemminger@vyatta.com, dada1@cosmosbay.com, frank.blaschka@de.ibm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Bart Trojanowski Return-path: Received: from stinky.trash.net ([213.144.137.162]:58170 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751192AbZCEFwA (ORCPT ); Thu, 5 Mar 2009 00:52:00 -0500 In-Reply-To: <20090305045925.GG5959@jukie.net> Sender: netdev-owner@vger.kernel.org List-ID: Bart Trojanowski wrote: >>> As analyzed by Patrick McHardy, vlan needs to reset it's >>> netdev_ops pointer in it's ->init() function but this >>> leaves the compat method pointers stale. >>> >>> Add a netdev_resync_ops() and call it from the vlan code. >> >>> include/linux/netdevice.h | 1 + >>> net/8021q/vlan_dev.c | 1 + >>> net/core/dev.c | 54 +++++++++++++++++++++++++++----------------- >>> 3 files changed, 35 insertions(+), 21 deletions(-) >> I tried this patch onto v2.6.29-rc7-3-g559595a, but I still get a crash. >> I assume that this worked for you, so I am not putting much faith in my >> results at this late hour. I'll confirm tomorrow morning that it's not >> something else. > > ... if you're interested, here is the Oops. And like I said, I'll > retest tomorrow. Thanks, I'll try to reproduce it here.