netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* question on netlink_overrun()
@ 2009-03-05  1:18 Chris Friesen
  2009-03-05  5:56 ` Patrick McHardy
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Friesen @ 2009-03-05  1:18 UTC (permalink / raw)
  To: David S. Miller, Linux Network Development list

Hi all,

Currently we set netlink_overrun() on the socket in both the unicast and 
broadcast paths.  If I understand things correctly this should result in 
the receiver getting ENOBUFS the next time they try a socket-related 
syscall.

However, in the netlink_dump() code we don't call it--was this an 
oversight or an intentional design decision?

I have a userspace app that would like to know if it ran out of buffer 
space in the receive socket (and hence lost some packets) while dumping 
SA information in xfrm_user_rcv_msg().

Thanks,

Chris

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: question on netlink_overrun()
  2009-03-05  1:18 question on netlink_overrun() Chris Friesen
@ 2009-03-05  5:56 ` Patrick McHardy
  0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2009-03-05  5:56 UTC (permalink / raw)
  To: Chris Friesen; +Cc: David S. Miller, Linux Network Development list

Chris Friesen wrote:
> Currently we set netlink_overrun() on the socket in both the unicast and 
> broadcast paths.  If I understand things correctly this should result in 
> the receiver getting ENOBUFS the next time they try a socket-related 
> syscall.
> 
> However, in the netlink_dump() code we don't call it--was this an 
> oversight or an intentional design decision?
> 
> I have a userspace app that would like to know if it ran out of buffer 
> space in the receive socket (and hence lost some packets) while dumping 
> SA information in xfrm_user_rcv_msg().

The dump should never overrun since it has flow control based
on available socket memory. Once the decision has been made
to send a dump packet and it has been sucessfully allocated,
it is never dropped. Except when explicitly filtered.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-03-05  5:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-05  1:18 question on netlink_overrun() Chris Friesen
2009-03-05  5:56 ` Patrick McHardy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).