From: Patrick McHardy <kaber@trash.net>
To: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Cc: David Miller <davem@davemloft.net>,
bart@jukie.net, greearb@candelatech.com, shemminger@vyatta.com,
dada1@cosmosbay.com, frank.blaschka@de.ibm.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG] 2.6.29-rc* QinQ vlan trunking regression
Date: Thu, 05 Mar 2009 09:27:12 +0100 [thread overview]
Message-ID: <49AF8CE0.6030301@trash.net> (raw)
In-Reply-To: <49AF87D6.5040104@linux.vnet.ibm.com>
Frank Blaschka wrote:
> Hi Dave, Patrick,
>
> sorry I could not follow the complete discussion of the fixes done for this problem
> but does
>
> if (netif_device_present(real_dev) && ops->ndo_neigh_setup)
> - err = ops->ndo_neigh_setup(dev, pa);
> + err = ops->ndo_neigh_setup(real_dev, pa);
>
> not change the idea of the neigh_setup? Remind we want the neigh_setup of the
> real device as the neigh setup function for the vlan device.
>
An we still use it. The only difference is that we pass it the
correct device reference, which not only fixes the recursion,
but is also expected by the callbacks. Look at bonding or simply
vlan itself.
The setup itself is still done using the neigh_params passed to
VLAN, which appears to be what was originally intended.
next prev parent reply other threads:[~2009-03-05 8:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-28 18:05 [BUG] 2.6.29-rc* QinQ vlan trunking regression Bart Trojanowski
2009-03-04 7:43 ` David Miller
2009-03-04 9:57 ` Patrick McHardy
2009-03-04 10:59 ` David Miller
2009-03-04 11:45 ` Patrick McHardy
2009-03-05 3:53 ` David Miller
2009-03-05 4:54 ` Bart Trojanowski
2009-03-05 4:59 ` Bart Trojanowski
2009-03-05 5:51 ` Patrick McHardy
2009-03-05 5:21 ` David Miller
2009-03-05 5:51 ` Patrick McHardy
2009-03-05 6:57 ` David Miller
2009-03-05 7:00 ` David Miller
2009-03-05 7:05 ` Patrick McHardy
2009-03-05 7:11 ` David Miller
2009-03-05 7:12 ` Patrick McHardy
2009-03-05 7:19 ` David Miller
2009-03-05 7:26 ` Patrick McHardy
2009-03-05 7:31 ` Patrick McHardy
2009-03-05 7:45 ` David Miller
2009-03-05 8:05 ` Frank Blaschka
2009-03-05 8:27 ` Patrick McHardy [this message]
2009-03-05 8:56 ` David Miller
2009-03-05 8:59 ` David Miller
2009-03-05 9:08 ` Patrick McHardy
2009-03-05 9:09 ` Patrick McHardy
2009-03-05 9:58 ` David Miller
2009-03-05 12:30 ` Maxime Bizon
2009-03-05 12:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AF8CE0.6030301@trash.net \
--to=kaber@trash.net \
--cc=bart@jukie.net \
--cc=blaschka@linux.vnet.ibm.com \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=frank.blaschka@de.ibm.com \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).