From: Ben McKeegan <ben@netservers.co.uk>
To: Ivan Vecera <ivecera@redhat.com>
Cc: netdev@vger.kernel.org, grundler@parisc-linux.org,
kyle@mcmartin.ca, Tomasz Lemiech <szpajder@staszic.waw.pl>
Subject: Re: [PATCH] tulip: Fix for MTU problems with 802.1q tagged frames
Date: Fri, 06 Mar 2009 12:48:38 +0000 [thread overview]
Message-ID: <49B11BA6.7060103@netservers.co.uk> (raw)
In-Reply-To: <1236248494-1599-1-git-send-email-ivecera@redhat.com>
Ivan Vecera wrote:
> The original patch was submitted last year but wasn't discussed or applied
> because of missing maintainer's CCs. I only fixed some formatting errors,
> but as I saw tulip is very badly formatted and needs further work.
>
> Original description:
> This patch fixes MTU problem, which occurs when using 802.1q VLANs. We
> should allow receiving frames of up to 1518 bytes in length, instead of
> 1514.
>
> Based on patch written by Ben McKeegan for 2.4.x kernels. It is archived
> at http://www.candelatech.com/~greear/vlan/howto.html#tulip
> I've adjusted a few things to make it apply on 2.6.x kernels.
>
> Tested on D-Link DFE-570TX quad-fastethernet card.
>
> Signed-off-by: Tomasz Lemiech <szpajder@staszic.waw.pl>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Looks good. FWIW:
Signed-off-by: Ben McKeegan <ben@netservers.co.uk>
next prev parent reply other threads:[~2009-03-06 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 10:21 [PATCH] tulip: Fix for MTU problems with 802.1q tagged frames Ivan Vecera
2009-03-06 12:48 ` Ben McKeegan [this message]
2009-03-06 18:13 ` Grant Grundler
2009-03-13 22:43 ` David Miller
2009-03-08 19:53 ` Kyle McMartin
-- strict thread matches above, loose matches on Subject: below --
2008-04-15 21:18 [PATCH] [TULIP] " Tomasz Lemiech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B11BA6.7060103@netservers.co.uk \
--to=ben@netservers.co.uk \
--cc=grundler@parisc-linux.org \
--cc=ivecera@redhat.com \
--cc=kyle@mcmartin.ca \
--cc=netdev@vger.kernel.org \
--cc=szpajder@staszic.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).