From: Nicolas Dichtel <nicolas.dichtel@dev.6wind.com>
To: netdev <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>
Subject: XFRM state hash value
Date: Tue, 10 Mar 2009 10:46:03 +0100 [thread overview]
Message-ID: <49B636DB.7010004@dev.6wind.com> (raw)
Hi guys,
this commit: [XFRM]: Hash xfrm_state objects by source address too.
(http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commitdiff;h=c1969f294e624d5b642fc8e6ab9468b7c7791fa8)
introduces src address in hash for state.
But in some cases, source address is a wildcard when state is inserted. For
example, we can have something like this:
# setkey -c
add :: ff02::9 ah 0x100 -m transport -A hmac-md5 "cle3goldorakcle3";
In this case, __xfrm_state_insert() will calculate the hash value with src
address set to 0, but xfrm_state_find() will use the real source address to
calculate this hash. At the end, no state will be found.
The most simple way to resolve this pb is to revert the previous patch, but
maybe someone has a better idea...
Regards,
Nicolas
next reply other threads:[~2009-03-10 9:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 9:46 Nicolas Dichtel [this message]
2009-03-10 11:20 ` XFRM state hash value David Miller
2009-03-10 14:08 ` Nicolas Dichtel
2009-03-10 14:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B636DB.7010004@dev.6wind.com \
--to=nicolas.dichtel@dev.6wind.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).