From: Brian Haley <brian.haley@hp.com>
To: John Dykstra <john.dykstra1@gmail.com>
Cc: Thomas Backlund <tmb@mandriva.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: BUG when unloading bonding on 2.6.29-rc7-git3
Date: Wed, 11 Mar 2009 10:47:14 -0400 [thread overview]
Message-ID: <49B7CEF2.2000409@hp.com> (raw)
In-Reply-To: <1236727393.7958.38.camel@Maple>
John Dykstra wrote:
> ipv6: Fix BUG when disabled ipv6 module is unloaded
>
> Do not try to "uninitialize" ipv6 if its initialization had been skipped
> because module parameter disable=1 had been specified.
>
> Reported-by: Thomas Backlund <tmb@mandriva.org>
> Signed-off-by: John Dykstra <john.dykstra1@gmail.com>
> ---
> net/ipv6/af_inet6.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
> index da944ec..a0f1798 100644
> --- a/net/ipv6/af_inet6.c
> +++ b/net/ipv6/af_inet6.c
> @@ -1192,6 +1192,9 @@ module_init(inet6_init);
>
> static void __exit inet6_exit(void)
> {
> + if (disable_ipv6)
> + return;
> +
> /* First of all disallow new sockets creation. */
> sock_unregister(PF_INET6);
> /* Disallow any further netlink messages */
Acked-by: Brian Haley <brian.haley@hp.com>
Thanks for fixing this John.
Sorry, this was in the original patch I tested here, but somehow didn't make it
into what I sent to Dave.
-Brian
next prev parent reply other threads:[~2009-03-11 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 20:15 BUG when unloading bonding on 2.6.29-rc7-git3 Thomas Backlund
2009-03-10 20:38 ` Jay Vosburgh
2009-03-10 23:23 ` John Dykstra
2009-03-11 14:47 ` Brian Haley [this message]
2009-03-11 16:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B7CEF2.2000409@hp.com \
--to=brian.haley@hp.com \
--cc=john.dykstra1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tmb@mandriva.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).