From: Ivan Vecera <ivecera@redhat.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Dave Jones <davej@redhat.com>, Mikael Pettersson <mikpe@it.uu.se>,
Tim Durack <tdurack@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] r8169: revert "r8169: read MAC address from EEPROM on init (2nd attempt)"
Date: Mon, 16 Mar 2009 15:29:43 +0100 [thread overview]
Message-ID: <49BE6257.5070008@redhat.com> (raw)
In-Reply-To: <20090315111050.GB17800@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> It fails on the following systems:
> - RTL8169sc/8110sc (XID 18000000)
> reported by Tim Durack <tdurack@gmail.com> (x86)
> - RTL8169sb/8110sb (XID 10000000)
> reported by Mikael Pettersson <mikpe@it.uu.se> (ARM)
>
> The patch appeared to work on x86 for the following systems:
> RTL8169sb/8110sb 10000000 PCI (EXT)
> RTL8110s 04000000 PCI (EXT)
> RTL8102e 24a00000 PCI-E (LOM)
> RTL8168c/8111c 3c2000c0 PCI-E (LOM)
> RTL8168b/8111b 38000000 PCI-E (LOM)
> RTL8168b/8111b 38000000 PCI-E (EXT)
>
> The patch exposes two problems:
> 1) while not completely wrong, mac addresses are not read correctly
> from the EEPROM
> 2) the MAC address registers are not correctly set
>
Maybe it should be better to introduce a module param to disable/enable
this feature instead of the removal.
Ivan
prev parent reply other threads:[~2009-03-16 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 11:10 [PATCH 2/2] r8169: revert "r8169: read MAC address from EEPROM on init (2nd attempt)" Francois Romieu
2009-03-16 0:53 ` Mikael Pettersson
2009-03-16 3:04 ` David Miller
2009-03-16 14:29 ` Ivan Vecera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BE6257.5070008@redhat.com \
--to=ivecera@redhat.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=mikpe@it.uu.se \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=tdurack@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).